-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding PowerFactory implementation of distributed solar PVD1 #267
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have now rebased this extension onto master (with the now merged #266). However, this extension has still a number of issues:
- structural problems in
StaVmeas
due to conditional inputs not implemented correctly - missing description strings in all the models
- missing documentation of the models
- untidy diagrams
@tinrabuzin could you have a look otherwise we have to postpone this merge to the future.
BTW, I had to squash and rebase, so when working on this do a hard reset of your checkout branch. |
I don't have any time right now to fix this, sorry. Eventually, I will look into it. |
@tinrabuzin That is fine. Since these are additional models there is no rush. So I'm gonna reassign the milestone again for the next release. |
This PR is now rebased onto the latest v3.1.0-dev master |
This should probably be merged after #266.