Fixes#511 Transform the quick fixes which use ImplementInterfaceProposal to implement the code action participant extension point. #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… EE code actions. Signed-off-by: Michael Glavassevich <[email protected]>
…handler-poc Proof-of-concept for unifying the design for MicroProfile and Jakarta EE code actions.
…mentationQuickFix and ListenerImplementationQuickFix
…kFix and wrote test cases for same
…kFix and wrote test cases for same
…iberty#23 Part of OpenLiberty#511: Refactor the implementation for FilterImplementationQuickFix and ListenerImplementationQuickFix
…rfaceProposal_quickfix
… xml 1. Updated plugin.xml with correct targetDiagnostics. 2. Removed the createCodeAction method written in quick fix file and used the method from JDTUtils.
...a/io/openliberty/tools/intellij/lsp4jakarta/lsp4ij/servlet/FilterImplementationQuickFix.java
Outdated
Show resolved
Hide resolved
...va/io/openliberty/tools/intellij/lsp4jakarta/lsp4ij/codeAction/JakartaCodeActionHandler.java
Outdated
Show resolved
Hide resolved
...va/io/openliberty/tools/intellij/lsp4jakarta/lsp4ij/codeAction/JakartaCodeActionHandler.java
Outdated
Show resolved
Hide resolved
...io/openliberty/tools/intellij/lsp4jakarta/lsp4ij/servlet/ListenerImplementationQuickFix.java
Outdated
Show resolved
Hide resolved
2 tasks
mrglavas
approved these changes
May 13, 2024
There was a problem hiding this comment.
Looks good. Thanks for opening eclipse/lsp4jakarta#521 to cover adding the new tests to LSP4Jakarta.
aparnamichael
merged commit 596c531
into
OpenLiberty:code-action-unification-2
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #511
Refactored the following quick fixes :
These PR contains changes from Dessina's fork as well.