Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added validation for invalid command and params #175

Merged
merged 21 commits into from
Oct 23, 2019
Merged

Added validation for invalid command and params #175

merged 21 commits into from
Oct 23, 2019

Conversation

0xsarvesh
Copy link
Contributor

@0xsarvesh 0xsarvesh commented Oct 9, 2019 •
edited
Loading

Fixes #162
Added validations for subcommand, required args and input values.

⚠️ Merge after #184

@0xsarvesh
Copy link
Contributor Author

This PR is not ready for review.
Integration test fails, it may require some changes to dev chain docker image.
CC @deepesh-kn @gulshanvasnani

@0xsarvesh
Copy link
Contributor Author

Ready for review.

abhayks1
abhayks1 suggested changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@abhayks1 abhayks1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 🥇
Please see inline comments 📔

src/Directory.ts Show resolved Hide resolved
src/Node/ChainInfo.ts Show resolved Hide resolved
src/bin/Validator.ts Outdated Show resolved Hide resolved
src/bin/Validator.ts Outdated Show resolved Hide resolved
src/bin/Validator.ts Outdated Show resolved Hide resolved
src/bin/mosaic-logs.ts Show resolved Hide resolved
src/bin/mosaic-stop.ts Show resolved Hide resolved
src/bin/mosaic-verify-chain.ts Show resolved Hide resolved
src/lib/SubGraph.ts Show resolved Hide resolved
src/bin/mosaic-setup-redeem-pool.ts Show resolved Hide resolved
@0xsarvesh 0xsarvesh assigned 0xsarvesh and unassigned 0xsarvesh Oct 22, 2019
@abhayks1 abhayks1 self-assigned this Oct 22, 2019
abhayks1
abhayks1 approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@abhayks1 abhayks1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@abhayks1 abhayks1 merged commit 7c7b2eb into OpenST:develop Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhayks1 abhayks1 abhayks1 approved these changes

Assignees

@abhayks1 abhayks1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Throw error for unknown mosaic commands
2 participants
@0xsarvesh @abhayks1