Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toplo with themes and skins #156

Merged
merged 29 commits into from
Mar 8, 2024
Merged

Toplo with themes and skins #156

merged 29 commits into from
Mar 8, 2024

Conversation

Nyan11
Copy link
Collaborator

@Nyan11 Nyan11 commented Feb 1, 2024

Fix: #155

It is a PR to make Pyramid compatible with Toplo.

You need to validate the pull request on Bloc-Serialization at: OpenSmock/Bloc-Serialization#14.

Attention when this version will be merged it will possibily break all projects that currently use Pyramid.

It change the serialization (all examples are brokens + all specials widget (switch and visibility).
It change deep mechanics inside Pyramid.

@Nyan11
Copy link
Collaborator Author

Nyan11 commented Feb 1, 2024

What's comming:
image

@Nyan11 Nyan11 requested a review from labordep February 1, 2024 17:35
@labordep labordep added enhancement New feature or request bug Something isn't working and removed bug Something isn't working labels Feb 1, 2024
@labordep labordep added this to the alpha 5 milestone Feb 1, 2024
@labordep
Copy link
Member

labordep commented Feb 1, 2024

Thanks @Nyan11

You need to validate the pull request on Bloc-Serialization at: OpenSmock/Bloc-Serialization#14.

Ok, I have a review with comments.

Attention when this version will be merged it will possibily break all projects that currently use Pyramid.

No problem this is an alpha version and this is normal to introduce problems between them.

Copy link
Member

@labordep labordep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments + waiting for pharo-graphics/Toplo#97 + waiting for alpha 4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for this new baseline.
I don't think this is usefull to have separate version because users have to use Toplo... however if we succeed to execute CI in these two baselines it is a good practice to have a better architecture.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, do you have the problem on your PC ?
pharo-graphics/Bloc#356

Copy link
Member

@labordep labordep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update CI scripts.

self toploPackages: spec.

"Groups"
spec group: 'default' with: #( 'PyramidBloc' 'PyramidToplo' ). "complete version"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename PyramidBloc->Bloc and PyramidToplo-> Toplo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oups seems not possible to do that :(

@labordep
Copy link
Member

labordep commented Mar 8, 2024

TODO: This script should load with Toplo by default:

Metacello new
	baseline: 'Pyramid';
	repository: 'github://OpenSmock/Pyramid:main/src';
	load

@labordep
Copy link
Member

labordep commented Mar 8, 2024

@Nyan11 I think the example PyramidToploExamples>>buttons need to be recreate because there is an exception on opening. And this is strange because ToElement have serialized children :/

@Nyan11
Copy link
Collaborator Author

Nyan11 commented Mar 8, 2024

@Nyan11 I think the example PyramidToploExamples>>buttons need to be recreate because there is an exception on opening. And this is strange because ToElement have serialized children :/

I will check it

@Nyan11
Copy link
Collaborator Author

Nyan11 commented Mar 8, 2024

We need to load the dev branch of Toplo but currently the dev branch of Toplo is bugged

@Nyan11
Copy link
Collaborator Author

Nyan11 commented Mar 8, 2024

@labordep Everything should work, but you need to merge first: OpenSmock/Toplo-Serialization#1 and: pharo-graphics/Toplo#123 . You should check on your side if everithing is ok before merging.

Toplo-Serialization -> If we have a ToElement, it should serialized itt's children. If we have anything with TToPlaceHolder trait it should serialize it's children. Everithing else should not serialize it's children.

Toplo -> There is a bug that make impossible to instanciate ToElement currently on master ... (it also break the tests of Toplo-Serialization)

@labordep
Copy link
Member

labordep commented Mar 8, 2024

@labordep Everything should work, but you need to merge first: OpenSmock/Toplo-Serialization#1 and: pharo-graphics/Toplo#123 . You should check on your side if everithing is ok before merging.

Toplo-Serialization -> If we have a ToElement, it should serialized itt's children. If we have anything with TToPlaceHolder trait it should serialize it's children. Everithing else should not serialize it's children.

Toplo -> There is a bug that make impossible to instanciate ToElement currently on master ... (it also break the tests of Toplo-Serialization)

Ok I can launch the example, but buttons are all the same:

image

@Nyan11 I'm trying to reload a new image from scratch.

@Nyan11
Copy link
Collaborator Author

Nyan11 commented Mar 8, 2024

Do you have this ?

image

It is a menu to select the theme

@labordep
Copy link
Member

labordep commented Mar 8, 2024

Do you have this ?

image

It is a menu to select the theme

Yes good!
But when I save and re-edit the theme that I choose is not recovered. Is it normal?

@Nyan11
Copy link
Collaborator Author

Nyan11 commented Mar 8, 2024

Yes i did not implement a way to save the default theme for the space.

@Nyan11
Copy link
Collaborator Author

Nyan11 commented Mar 8, 2024

It is complicated, since it only saves the BlElements inside the space and not directly the space ...

@labordep
Copy link
Member

labordep commented Mar 8, 2024

It is complicated, since it only saves the BlElements inside the space and not directly the space ...

Ok thanks @Nyan11, we will discuss on that later.

@labordep labordep merged commit acb1b2a into main Mar 8, 2024
6 checks passed
@Nyan11 Nyan11 deleted the Issue_0155 branch May 1, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stamps and ids for toplo + stylesheet theme
2 participants