Extend functionality of poise rewrite #24
Conversation
- now locking to serenity 0.12 - poise current until it releases a new version - octocrab has been bumped enough to fix the conflict (any further breaks stuff)
thanks boid
- Cleanup some comments - added pre command hook to announce when commands begin execution - restored comments for creating and editing snippets
Also moves the event handler into the events directory
jamesbt365
force-pushed
the
poise-tb-unique-features
branch
from
5b7a1e6
to
0cbffbc
Compare
|
I've gone ahead and pushed the rwlock change and partial edit embed support. Some growing pains exist when handling edit embed because i'm editing the embed directly then turning it into a builder as this allows you to actually check what fields are set if you want better error handling. Also CreateEmbed doesn't allow you to unset things, so I'll rewrite the command eventually to build embeds from scratch using the current details of the embed, this hopefully will mitigate every problem with it. |
|
Gone ahead and reworked the command, don't really know how to get around move issues nicely when using map for everything so its a bit scuffed currently, I also don't think the colour logic that infinity originally implemented is optimal I think it can be improved lots. |
- Also disables all events in dms, as these aren't needed.
jamesbt365
changed the title
|
Merging the contents of this pull request into #23. |
depends on #23
Fixes #22
Fixes #21
Fixes #18
based on #23 because its already big enough and I wanted to split things up a little bit.
diff: jamesbt365/TabletBot@poise...jamesbt365:TabletBot:poise-tb-unique-features
Will convert to a RwLock shortly, finish the commands, fix hopefully everything and add migration (tabletbot will panic on read() if
issue_prefixesis not present.Somebody PLEASE look at that regex and see if you can improve it 🥺