rebase to serenity@next #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uhhhhh
supersedes #41
As the above PR, will not compile as is. Waiting on rustc update in nixpkgs.
Rundown of the fun
CreateEmbedwith internal referencesTypeMaplet Some(x)conditions in more places where diversion already happenedI could tweak the interaction code here but I already opened issues to clean it up (#36 and #32)
May open an additional PR in the future to use
FixedStringswe can, I don't wanna mess around with the pagination logic and the matching logic (which mutates a string so I can't just throw it everywhere)