Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating linked-gtfs to latest GTFS spec #20

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Shghazy
Copy link

@Shghazy Shghazy commented Jan 24, 2022

No description provided.

@Shghazy
Copy link
Author

Shghazy commented Jan 24, 2022

This is an update of the classes in gtfs. The details are as follows:

  1. Added 6 new primary classes: Attribution, Block, Level, Pathway, Location, and Translation
  2. Deleted ServiceRule and CalendarRule classes. Updated CalendarDateRule's usage.
  3. Added a new subclass to PickupType and DropOffType to represent the continuous stops in gtfs.
  4. Added 4 subclasses to Location: BoardingArea, GenericNode, Platform, and Station Entrance.
  5. Made Stop, Station, and Zone, subclasses of Location and updated their comments.
  6. Added 7 instances of Pathway: Elevator, Escalator, ExitGate, FareGate, MovingSidewalk, Stairs, Walkway
  7. Changed CableCar to CableTram, and changed Gondola to CableCar.
  8. Added Monorail and Trolleybus as new RouteType instances.

@pietercolpaert
Copy link
Member

wrt block: #16

@pietercolpaert
Copy link
Member

Included in this PR is the update of deprecating ServiceRule: a service id in the latest GTFS spec can only appear once in the calendar.txt. We will update our vocabulary towards only Service and CalendarDateRule as classes.

Copy link
Member

@pietercolpaert pietercolpaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add adms:versionNotes to CableCar and a deprecated Gondola

@Shghazy
Copy link
Author

Shghazy commented Mar 13, 2022

Commit #265bdad
New object properties added:

  • containsZone, - continuousDropOffType, - continuousPickupType, - destination, - fare, - level, - origin, - pathwayMode, - translation

Comment and range changes for:

  • block, - dropOffType, - pickupType, -routeType, -service, - shape, - transferType

Questions to consider:

  1. Should we have a different property for originStop/destinationStop for pathways and transfers?
  2. Is the way multiple range options is represented correct for gtfs:pathwayMode?

@Shghazy Shghazy changed the title Updating gtfs classes to latest GTFS spec Updating linked-gtfs to latest GTFS spec Mar 13, 2022
@Shghazy
Copy link
Author

Shghazy commented Mar 20, 2022

Commit #8566ab1

New data properties added:

  • locationCode, - platformCode, - contactUrl, - defaultLanguage, - index, - isAuthority, - bidirectional, - isOperator, - isProducer, - length, - maxSlope, - minWidth, - reversedSignpostedAs, -signpostedAs, - sortOrder, - stairCount, - timepoint, - timezone, - transferDuration, - traversalTime,

Comment changes for:

  • color, -direction, - longName, - minimumTransferTime, - monday, - tuesday, - wednesday, - thursday, - friday, - saturday, - sunday, - pointSequence, - textColor, - usesExactTimes

@pietercolpaert
Copy link
Member

@Shghazy I’m terribly sorry that it took so long to comment. I think the updates to the vocabulary .ttl file are great and can be accepted. However, the spec.md, the human readable document also need to be updated. Would you like to take the lead on that? https://github.com/OpenTransport/linked-gtfs/blob/master/spec.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants