Use a custom tooltip window for the tray icon #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the idea, but do not feel qualified today to ACK or NAK the code. @lstipakov something for you? |
selvanair
force-pushed
the
notify-icon
branch
from
0c84fc1
to
46421d8
Compare
|
Hi, On Windows 11 there are two issues;
|
|
linking to my comment #666 (comment) |
Built-in tray notification icon has a tip text length limit of 128
characters which is often limited for showing the connected profile name,
connected since time and IP addresses. If the profile name is long the IP
numbers could get truncated.
Fix by using a custom tooltip window and display it when mouse hovers over
the icon. As the status bar need not be at the bottom of the screen (could be
at right, left or top as well), the location of the window is chosen based
on the mouse co-ordinates that trigger the hover event.
In case of errors while setting up the tooltip window, fall back to the current
behaviour.
If the message is too long to include time and IP, truncate the profile name
part of the message.
v2: Do not use wParam in NIN_POPUOPEN message as it does not seem to work
on Windows 11. Instead use GetCursorPos() for mouse location.
Fixes issue OpenVPN#666
Signed-off-by: Selva Nair <[email protected]>
selvanair
force-pushed
the
notify-icon
branch
from
46421d8
to
22839ea
Compare
|
Force pushed with changes:
|
|
(Moving this to the right place) On Win11 the tip window should probably have more rounded corners, but will leave it at that. |
Also change scope of tip_msgi[] to local Co-authored-by: Lev Stipakov <[email protected]> Signed-off-by: Selva Nair <[email protected]>
Use Shell_NotifyGetRect to find the icon location and place the tip window a fixed distance above/below it. It appears GUID_NULL used for above is not pulled in by shellapi.h. Define locally when absent. Also add TTF_RTLREADING for RTL languages. How to right justify as well in this case is unclear. Signed-off-by: Selva Nair <[email protected]>
selvanair
force-pushed
the
notify-icon
branch
from
021cb54
to
1209028
Compare
lstipakov
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built-in tray notification icon has a tip text length limit of 128 characters which is often limited for showing the connected profile name, connected since time and IP addresses. If the profile name is long the IP numbers could get truncated.
Fix by using a custom tooltip window and display it when mouse hovers over the icon. As the status bar need not be at the bottom of the screen (could be at right, left or top as well), the location of the window is chosen based on the mouse co-ordinates that trigger the hover event.
In case of errors while setting up the tooltip window, fall back to the current behaviour.
If the message is too long to include time and IP, truncate the profile name part of the message.
Fixes issue #666
Edit: force pushed after fixing some typos in commit message and buggy text truncation logic.
old
new