Update openvpn-gui-res-zh-hans.rc #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selvanair
reviewed
Sep 20, 2024
res/openvpn-gui-res-zh-hans.rc
Outdated
| @@ -561,7 +561,7 @@ Wintun驱动程序将无法正常工作。" | |||
| IDS_NFO_AUTO_CONNECT "在 %u 秒后自动连接..." | |||
| IDS_NFO_CLICK_HERE_TO_START "OpenVPN GUI 已经运行. 右击任务栏图标启动." | |||
| IDS_NFO_BYTECOUNT "接收字节: %ls 发送字节: %ls" | |||
| IDS_NFO_OTP_PROMPT "Input OTP or passcode" | |||
| IDS_NFO_OTP_PROMPT "输入OTP或密码" | |||
There was a problem hiding this comment.
@justwho Thanks for the PR.
I asked a native speaker for comments and got an OK, but I have a concern:
Where this is used, the dialog asks for password (密码) and OTP with this pompt. Wouldn't the use of the same word "密码" in both places confuse users?
If there is no good translation for "passcode", would it be better to show this prompt as just "输入OTP" ?
There was a problem hiding this comment.
I also think using '输入OTP' is more appropriate.Thanks!!! @selvanair
There was a problem hiding this comment.
@justwho Could you please add a commit on top of this with that change? I can then squash during merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.