Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buildtap.py #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

peergine-admin
Copy link

No description provided.

@mattock
Copy link
Member

mattock commented Mar 6, 2020

@peergine-admin can you explain why this is useful/needed?

@peergine-admin
Copy link
Author

When the non-default language is English type windows operation runtime, for example, the default character set of Chinese Windows operating system is GBK. Stupid python will report an error here.
UnicodeDecodeError: 'gbk' codec can't decode byte 0xbf in position 2: illegal multibyte sequence

@mattock
Copy link
Member

mattock commented Mar 6, 2020

@peergine-admin ok, I see. This does, however, break appveyor builds:

***** BUILD TAP config
Traceback (most recent call last):
  File "buildtap.py", line 511, in <module>
    btw.build()
  File "buildtap.py", line 280, in build
    self.build_tap()
  File "buildtap.py", line 255, in build_tap
    self.config_tap()
  File "buildtap.py", line 197, in config_tap
    self.preprocess(kv, os.path.join(self.src, "OemVista.inf"))
  File "buildtap.py", line 189, in preprocess
    with open(in_path+'.in', encoding='utf_8_sig') as f:
TypeError: 'encoding' is an invalid keyword argument for this function

Can you check what might be causing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants