Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modifier types #205

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Modifier types #205

merged 1 commit into from
Sep 21, 2024

Conversation

Hop311
Copy link
Contributor

@Hop311 Hop311 commented Sep 20, 2024

These will be useful for organising modifiers in tooltips, e.g. collecting together tech into a single "From tech" line

@Hop311 Hop311 added the enhancement New feature or request label Sep 20, 2024
@Hop311 Hop311 changed the base branch from master to fix-modifiers September 20, 2024 21:46
BrickPi
BrickPi approved these changes Sep 21, 2024
View reviewed changes
Copy link
Contributor

@BrickPi BrickPi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, such a paradox thing to do having a dozen different modifier tooltip types under the hood.

@Hop311 Hop311 merged commit e35ff8e into fix-modifiers Sep 21, 2024
14 checks passed
@Hop311 Hop311 deleted the modifier-types branch September 21, 2024 07:03
Hop311 pushed a commit to Hop311/OpenVic-Simulation that referenced this pull request Oct 13, 2024
@Spartan322
Merge pull request OpenVicProject#205 from Spartan322/fixup/game-info
4bcf96c 
Add GameInfo button to MainMenu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrickPi BrickPi BrickPi approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hop311 @BrickPi