Skip to content
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.

Worked around the increased BDBR regression issue. #425

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Source/Lib/Codec/EbDefinitions.h
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ extern "C" {
typedef int errno_t;
#endif /* _ERRNO_T_DEFINED */



// To sharpen frame background.
#define USE_SOURCE_REFERENCE 0

//Maximum 8192x4320
#define EB_TILE_COLUMN_MAX_COUNT 20u
Expand Down
6 changes: 6 additions & 0 deletions Source/Lib/Codec/EbPictureDecisionProcess.c
Original file line number Diff line number Diff line change
Expand Up @@ -1020,9 +1020,15 @@ void* PictureDecisionKernel(void *inputPtr)

pictureControlSetPtr->disableTmvpFlag = sequenceControlSetPtr->staticConfig.unrestrictedMotionVector == 0 ? EB_TRUE : EB_FALSE;

// FIXME: work around the increased BDBR regression issue induced by the
// tile group implementation (PR #348), when ImproveSharpness is used.
#if USE_SOURCE_REFERENCE
pictureControlSetPtr->useSrcRef = (sequenceControlSetPtr->staticConfig.improveSharpness && pictureControlSetPtr->temporalLayerIndex > 0) ?
EB_TRUE :
EB_FALSE;
#else
pictureControlSetPtr->useSrcRef = EB_FALSE;
#endif

SignalDerivationMultiProcessesOq(
sequenceControlSetPtr,
Expand Down