Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Padatious intent handler registration with multiple native languages #148

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

NeonDaniel
Copy link
Member

Prevent creating duplicate event listeners when multiple languages are supported

@NeonDaniel NeonDaniel requested a review from a team November 16, 2023 01:32
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (4f65ac5) 60.23% compared to head (c738331) 59.63%.
Report is 11 commits behind head on dev.

Files Patch % Lines
ovos_workshop/skills/ovos.py 26.66% 33 Missing ⚠️
ovos_workshop/version.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #148      +/-   ##
==========================================
- Coverage   60.23%   59.63%   -0.60%     
==========================================
  Files          34       34              
  Lines        3347     3367      +20     
==========================================
- Hits         2016     2008       -8     
- Misses       1331     1359      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goldyfruit
Copy link
Member

Thanks for this fix @NeonDaniel it drove me crazy for the past few days...

@JarbasAl JarbasAl merged commit ad9b0c2 into dev Nov 16, 2023
15 of 17 checks passed
@JarbasAl JarbasAl deleted the FIX_DuplicateIntentHandlerRegistration branch November 16, 2023 02:38
This was referenced Dec 29, 2023
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants