Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/dialog_transformers #27

Merged
merged 8 commits into from
Oct 7, 2023
Merged

feat/dialog_transformers #27

merged 8 commits into from
Oct 7, 2023

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Oct 6, 2023

companion to OpenVoiceOS/ovos-plugin-manager#179

  • move PlaybackThread to ovos-audio
  • add DialogTransformers support
  • add TTSTransformers support

example plugins

utt = "Quantum mechanics is a branch of physics that describes the behavior of particles at the smallest scales. " \
    "It involves principles such as superposition, where particles can exist in multiple states simultaneously, " \
    "and entanglement, where particles become connected and can influence each other's properties."
print(lovecraftify(utt))
# Quantum mechanics unveils the eldritch secrets of the infinitesimal realm,
# where particles, ensnared in the web of superposition, dwell in manifold states.
# Through the dread phenomenon of entanglement, these entities intertwine,
# their very essence entwined, shaping the fabric of reality.
print(dudeify(utt))
# Quantum mechanics is like, the raddest branch of physics, dude.
# It's all about particles at the tiniest scales, doing crazy stuff like
# being in multiple states at once (superposition) and getting all connected and influencing each other (entanglement).
print(eli5(utt))
# Quantum mechanics is like a special kind of science that helps us understand really tiny things.
# It tells us that these tiny things can be in more than one place at the same time,
# and they can also be connected to each other and affect each other's behavior.

ties into OpenVoiceOS/ovos-persona#4

mycroft.conf

{
	"dialog_transformers": {
		"ovos-dialog-transformer-openai": {
			"key": "xxxxx",  
			"api_url": "https://api.openai.com/v1"},
			"rewrite_prompt": "Add more 'dude'ness to"
	},
   "tts_transformers": {
		"ovos-tts-transformer-sox": {
			"default_effects": {
				"pitch": {"n_semitones": int}
			}
		}
	}
}

@JarbasAl JarbasAl added the enhancement New feature or request label Oct 6, 2023
Copy link
Contributor

@mikejgray mikejgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know this codebase well enough to feel comfortable putting an approval on this PR, but I had some feedback and comments.

Could also benefit from some tests. 🙂

ovos_audio/transformers.py Show resolved Hide resolved
ovos_audio/transformers.py Show resolved Hide resolved
ovos_audio/playback.py Show resolved Hide resolved
ovos_audio/playback.py Show resolved Hide resolved
ovos_audio/playback.py Outdated Show resolved Hide resolved
ovos_audio/playback.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (dev@5cbb1c4). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev     #27   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?       8           
  Lines          ?     906           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?     906           
  Partials       ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl marked this pull request as ready for review October 7, 2023 21:09
@JarbasAl JarbasAl merged commit 819c5f1 into dev Oct 7, 2023
5 checks passed
@JarbasAl JarbasAl deleted the feat/dialog_transformers branch October 7, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants