-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/dialog_transformers #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know this codebase well enough to feel comfortable putting an approval on this PR, but I had some feedback and comments.
Could also benefit from some tests. 🙂
Co-authored-by: Mike <[email protected]>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #27 +/- ##
=====================================
Coverage ? 0.00%
=====================================
Files ? 8
Lines ? 906
Branches ? 0
=====================================
Hits ? 0
Misses ? 906
Partials ? 0 ☔ View full report in Codecov by Sentry. |
companion to OpenVoiceOS/ovos-plugin-manager#179
example plugins
ties into OpenVoiceOS/ovos-persona#4
mycroft.conf