Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:enable fake barge in by default #164

Merged
merged 1 commit into from
Oct 8, 2024
+1 −1
Merged

feat:enable fake barge in by default #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ovos_config/mycroft.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,7 +450,7 @@
"sample_rate": 16000,

// mute global audio output volume while microphone is recording
"fake_barge_in": false,
"fake_barge_in": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Potential Conflict Between fake_barge_in and mute_during_output

Enabling fake_barge_in while mute_during_output is set to false may allow the system to respond to wake words during audio playback, potentially causing unintended activations.

🔗 Analysis chain

Enabling fake barge-in by default

The fake_barge_in setting has been changed from false to true. This change allows the system to respond to wake words even during audio playback, potentially enhancing the voice assistant's responsiveness.

To ensure this change doesn't conflict with other settings, let's verify the related configurations:

This will help us confirm that the change is consistent with other related settings in the configuration file.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Check for any conflicting settings or dependencies
grep -n "fake_barge_in" ovos_config/mycroft.conf
grep -n "mute_during_output" ovos_config/mycroft.conf

Length of output: 171


// TODO - these names are confusing, update dinkum listener to give them more descriptive names
// min speech seconds for audio to be considered speech
Expand Down
Loading