Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ansible/venv] Comment eastereggs skill until PR is merged #190

Merged
merged 1 commit into from
Oct 19, 2024

Conversation

goldyfruit
Copy link
Member

@goldyfruit goldyfruit commented Oct 19, 2024

Commenting the skill installation until this OpenVoiceOS/ovos-skill-easter-eggs#47 got merged as it downgrade ovos-core to 2.3.0 which doesn't contain the fallback match OpenVoiceOS/ovos-core#572

Summary by CodeRabbit

  • Bug Fixes

    • Disabled the inclusion of the ovos-skill-easter-eggs skill when the profile is not set to "server", preventing potential issues.
  • Chores

    • Updated the template to improve clarity by commenting out the conditional block related to the GitHub repository.

@goldyfruit goldyfruit added the bug Something isn't working label Oct 19, 2024
@goldyfruit goldyfruit added this to the Wolfenstein milestone Oct 19, 2024
@goldyfruit goldyfruit self-assigned this Oct 19, 2024
Copy link
Contributor

coderabbitai bot commented Oct 19, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes involve modifications to the extra-skills-requirements.txt.j2 template file within the Ansible role for the OVOS installer. Specifically, a conditional block that included the ovos-skill-easter-eggs skill from a GitHub repository has been commented out. This change disables the inclusion of this skill unless the ovos_installer_profile is set to "server". Other entries for ovos-core and ovos-skill-icanhazdadjokes remain unchanged.

Changes

File Path Change Summary
ansible/roles/ovos_installer/templates/virtualenv/extra-skills-requirements.txt.j2 Commented out the inclusion of ovos-skill-easter-eggs skill based on ovos_installer_profile.

Possibly related PRs

  • use pypi #144: The changes in this PR also involve the extra-skills-requirements.txt.j2 template file, specifically adding new skills, which is directly related to the modifications made in the main PR that comments out a skill inclusion.

Poem

🐰 In the garden where skills do bloom,
A skill was hushed, lost in the gloom.
With a simple comment, it took a rest,
While others still shine, they are the best.
Hop along, dear friends, to a skillful delight,
For every change brings a new path to light! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@goldyfruit goldyfruit merged commit ff1ed1e into main Oct 19, 2024
7 checks passed
@goldyfruit goldyfruit deleted the fix/comment_eastereggs branch October 19, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant