Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new intent service/pipeline api #193

Closed
wants to merge 2 commits into from
Closed

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Sep 21, 2023

moves the backwards_compat decorator from ovos-workshop to also be used here

companion to OpenVoiceOS/ovos-core#349 + OpenVoiceOS/ovos-plugin-manager#177

TODO - document new bus events properly from pipeline plugins

# NOTE: these receive skill_id/name separately, not as part of munged names
  self.bus.on('intent.service:detach_intent', self.handle_detach_intent)
  self.bus.on('intent.service:detach_entity', self.handle_detach_entity)
  self.bus.on('intent.service:detach_skill', self.handle_detach_skill)
  self.bus.on('intent.service.register_intent', self.handle_register_intent)
  self.bus.on('intent.service.register_keyword_intent', self.handle_register_keyword_intent)
  self.bus.on('intent.service.register_regex_intent', self.handle_register_regex_intent)
  self.bus.on('intent.service:register_keyword', self.handle_register_keyword)
  self.bus.on('intent.service:register_entity', self.handle_register_entity)
  self.bus.on('intent.service:register_regex_entity', self.handle_register_regex_entity)
  self.bus.on('intent.service:train', self.handle_train)

compatibility with the previous api provided via @backwards_compat decorator

  # backwards compat handlers with adapt/padatious namespace
# NOTE: these receive munged intents, skill_id/name need to be extracted from name
  self.bus.on('padatious:register_intent', self.handle_register_intent)
  self.bus.on('padatious:register_entity', self.handle_register_entity)
  self.bus.on('register_vocab', self._handle_adapt_vocab)
  self.bus.on('register_intent', self.handle_register_keyword_intent)
  self.bus.on('detach_intent', self.handle_detach_intent)
  self.bus.on('detach_skill', self.handle_detach_skill)
  self.bus.on('mycroft.skills.initialized', self.handle_train)

moves the backwards_compat decorator from ovos-workshop to also be used here
@JarbasAl JarbasAl added the enhancement New feature or request label Sep 21, 2023
@JarbasAl JarbasAl requested review from NeonDaniel and a team September 21, 2023 19:12
JarbasAl added a commit to OpenVoiceOS/OVOS-workshop that referenced this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant