fix(BPU): fix potential bug on s2_fire_dup

[Jerry-Tianchen]

Detailed Issue please refer to issue: #3837

Close #3837

[eastonman]

I believe s3_fire has the same problem, can you fix it together?

XiangShan/src/main/scala/xiangshan/frontend/BPU.scala

Line 430 in dd16cea

s3_fire_dup := s3_valid_dup

[Jerry-Tianchen]

I believe s3_fire has the same problem, can you fix it together?

XiangShan/src/main/scala/xiangshan/frontend/BPU.scala

Line 430 in dd16cea

s3_fire_dup := s3_valid_dup

Sure.

[eastonman]

Hello, this is not yet updated for s3_fire_dup.
Umm, I suppose we will run CI after that.

[Jerry-Tianchen]

Hello, this is not yet updated for s3_fire_dup. Umm, I suppose we will run CI after that.

sorry my local git was messed up and I have not yet figured out a time to fix it. I don't want to push a "Merge" commit into the main repo.

But are you sure s3 also needs fixing? I reviewed it multiple times and I only see it being assigned once:
s3_fire_dup := s3_valid_dup

[eastonman]

Ok, I was wrong about s3_fire_dup. Will start a CI run after which this can be merged.
"Merge" commit will not be a problem because all the commits in a PR will be squashed into one.

[eastonman]

LGTM