Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CSR,RVC): c.fp instrs should be illegal when fs is off #3859

Merged
merged 2 commits into from
Nov 14, 2024
Merged

fix(CSR,RVC): c.fp instrs should be illegal when fs is off #3859

merged 2 commits into from
Nov 14, 2024

Conversation

ngc7331
Copy link
Collaborator

@ngc7331 ngc7331 commented Nov 11, 2024 •
edited
Loading

  • fix RVC floating-point inst raise EX_II in predecode when xstatus.fs is off

Fix #3864

Update: OpenXiangShan/rocket-chip#20 is merged and this PR is rebased, ready to review.

@sinceforYy @ngc7331
fix(csr): add fsIsOff in CustomCSRCtrlIO
8320f33 
* fix RVC inst raise EX_II in predecode when xstatus.fs is off
@ngc7331 ngc7331 marked this pull request as ready for review November 13, 2024 07:44
eastonman
eastonman approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@eastonman eastonman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 854b16a

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
854b16a 1.917 0.450 2.701 1.230 2.891 2.473 2.398 0.915 1.429 1.700 3.470 2.729 2.417 3.280

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
1bf9a59
5f89ba0 1.917 1.239 2.891 2.473 0.915 1.700 3.470 2.417 3.280
149e918
4e7f257 1.917 1.237 2.891 2.473 0.915 1.429 1.700 3.470 2.417 3.280
393755c 1.917 0.450 2.701 1.239 2.891 2.473 2.398 0.915 1.429 1.700 3.470 2.729 2.417 3.280

@Gao-Zeyu Gao-Zeyu merged commit 71b6c42 into master Nov 14, 2024
9 checks passed
@Gao-Zeyu Gao-Zeyu deleted the fix-rvc-fs branch November 14, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinceforYy sinceforYy sinceforYy approved these changes

@eastonman eastonman eastonman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@ngc7331 @XiangShanRobot @eastonman @sinceforYy @Gao-Zeyu