Add upgrade_and_call #1148
Add upgrade_and_call #1148
Conversation
|
|
||
| Replaces the contract's class hash with `new_class_hash` and then calls `selector` | ||
| from the upgraded context. | ||
|
|
There was a problem hiding this comment.
I would add a note mentioning that should be kept in mind that the call is executed from the upgraded contract itself, and not the calling account, since they may have some implications in the setup.
Also, another note that could be helpful is that with native account abstraction, and multicall being part of SNIP6, this behavior could be achieved by using just upgraded and putting the extra call in the second element of the list of calls. Then the call would be executed from the account itself, and can't be front-runned.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1148 +/- ##
==========================================
+ Coverage 88.87% 88.90% +0.03%
==========================================
Files 57 57
Lines 1375 1379 +4
==========================================
+ Hits 1222 1226 +4
Misses 153 153
Continue to review full report in Codecov by Sentry.
|
| } | ||
|
|
||
| #[test] | ||
| #[ignore] // REASON: |
There was a problem hiding this comment.
Let's not forget to add a reason or un-ignore the test
Co-authored-by: immrsd <[email protected]>
Fixes #694.
This PR proposes to add
upgrade_and_callto UpgradeableComponent's InternalImpl. This PR also proposes to addIUpgradeAndCallinterface which includes bothupgradeandupgrade_and_call.PR Checklist