Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client.UpdateService needed v2 of ServiceUpdateInput #321

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

davidbloss
Copy link
Contributor

Resolves #

Problem

Solution

Checklist

  • I have run this code, and it appears to resolve the stated issue.
  • This PR has no user interface changes or has already received approval from product management to change the interface.
  • Make a changie entry that explains the customer facing outcome of this change

@rocktavious
Copy link
Collaborator

@davidbloss so after extensive testing with the latest released version I was not able to reproduce the originally stated issue. Then after testing with this version it seems to work exactly the same. So i'm not sure whats going on but either way we should be using the updated input payload and i've taken to fixing the task file to rip out the nilaway and forced opslevel-go update.

Thoughts?

@davidbloss
Copy link
Contributor Author

... i've taken to fixing the task file to rip out the nilaway and forced opslevel-go update.

Thoughts?

Agreed that taking out nilaway from the taskfile is a great move. But I think we should keep the opslevel-go version update task for now, and remove it's actual usage on line 30. This logic will likely be helpful when we make the various tool deploys more automated later on

@rocktavious
Copy link
Collaborator

@davidbloss I only removed has-latest-opslevel-dependencies which is a check not a thing that updates. There is still a non-internal task update-opslevel-deps to help with manually choosing to update the deps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants