[doc] add FAQ placeholder, add note on arguments for training #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added small note under training section, added placeholder for to-be FAQ section.
shizhediao
approved these changes
Jan 1, 2025
| @@ -65,6 +66,7 @@ LoRA is a parameter-efficient finetuning algorithm and is more efficient than fu | |||
| ```sh | |||
| bash run_finetune_with_lora.sh | |||
| ``` | |||
| Note: Please double-check that you have updated the [training script](https://raw.githubusercontent.com/OptimalScale/LMFlow/refs/heads/data-challenge/run_finetune_with_lora.sh) with the correct arguments for your use case. | |||
There was a problem hiding this comment.
I think we expect every participant use the exactly the same arguments, which should be provided by us.
Let's mark this in our note. We will do that.
There was a problem hiding this comment.
@shizhediao I see, makes sense!
Let's mark this in our note
Marked in the internal note, thanks for the heads up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added small note under training section, added placeholder for to-be FAQ section.