Support for using go sdk v2, Fix Network Firewall #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjfish25
commented
Jul 1, 2024
bjfish25
commented
- due to aws-go-sdk is now deprecated and will reach eol in 2025, add support for using the v2 apis and auth
- cloudcontrol network firewall doesn't delete if logging configurations exists
- remove from cloudcontrol
- add specific resource to delete with logging configs in mind
dilip0515
previously approved these changes
Jul 21, 2024
bjfish25
force-pushed
the
go-sdk-v2-network-firewall
branch
from
b93b3c9
to
f298670
Compare
dilip0515
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.