Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profitability check general tool #1984

Draft
wants to merge 78 commits into
base: master
Choose a base branch
from

Commits on Jun 14, 2023

  1. initail commit

    sparrowDom committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    21d28ff View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. Configuration menu
    Copy the full SHA
    ca4b9c7 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. intermediary commit

    sparrowDom committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    bd17a59 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. commit research files

    sparrowDom committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    e218397 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. balancer booster abi

    sparrowDom committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    e40539a View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. intermittent commit

    sparrowDom committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    fddfc96 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Configuration menu
    Copy the full SHA
    4d61080 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Configuration menu
    Copy the full SHA
    c941766 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4e2a0ac View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. intermittent commit

    sparrowDom committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    a163e8f View commit details
    Browse the repository at this point in the history
  2. add deployment file

    sparrowDom committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    6322507 View commit details
    Browse the repository at this point in the history
  3. add fork test fixture

    sparrowDom committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    5150986 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. intermittent commit

    sparrowDom committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    fa5838b View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. prettier

    sparrowDom committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    74f1403 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Configuration menu
    Copy the full SHA
    10b6fdc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    807e8c4 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2023

  1. prettier + lint

    sparrowDom committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    8f16b4e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1c782a5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    faa7eb5 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Configuration menu
    Copy the full SHA
    c6b45c3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c77a296 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. Balancer review changes (#1726)

    * Generated contract docs
    
    * Refactor Balancer storage variables
    
    * Small Balancer changes
    
    * Natspec updates
    Added missing licensing
    getPoolAssets gas optimized
    
    * Updated generated Balancer strategy contract diagrams
    
    * fix contract linter
    
    * Removed restrictions on tests
    
    * Small gas improvements
    Fixed Slither
    
    * Change BalancerError version
    
    * Updated constant names
    Addresses to use checksum format
    
    * JS lint tasks
    
    * Updated Balancer and Aura pool id constants
    
    * Removed getRateProviderRate as it wasn't being used
    Refactored to remove poolAssetsMapped storage variable
    
    * Updated OETH Contracts diagrams
    Generated new Balancer contract diagrams
    
    * Fix failing test
    
    * Fix merge conflict
    
    * Restored getRateProviderRate
    
    * Natspec updates
    Added toPoolAsset override
    
    * Removed unused getRateProviderRate
    
    * Natspec updates
    Gas optimization of InitializableAbstractStrategy
    
    * Abstract strategy gas improvements (#1719)
    
    * Refactor base strategy to use immutables
    
    * Fixed strategy deployments in 001_core and fixtures
    
    * Generated new strategy diagrams
    
    * Deploy rETH instead of the stETH Balancer MetaStable Pool
    
    * removed unused Aura config
    
    * Balancer fork tests
    
    * Added check that BPT amount equals Aura LP amount
    Added rETH conversion to ETH value
    
    * Updated balancer strat fork tests
    
    * Updated Balancer fork tests
    
    * Added optional deposit with multiple assets to the strategy
    
    * Single asset deposit to use multi asset deposit
    
    * Added optional checkBalance to Balancer strategy
    
    * Added checkBalance() to BaseBalancerStrategy
    
    * Fix slither
    Fix curve HH task
    
    * Added multi-asset withdraw to balancer strategy
    
    * Fix multi-asset withdraw
    
    * Updated Balancer and Vault diagrams
    
    * Fix js linter
    
    * Fixed checkBalance of rETH asset in Balancer strategy
    
    * Only wrap assets if amount > 0
    Added depositAll fork test for Balancer strat
    
    * Removed Vault changes for multi-asset strategy support
    
    * Updated generated docs
    
    * Add tests for wstETH/WETH Balancer pool (#1725)
    
    * Split deployment and fix fixtures
    
    * Deposit tests for wstETH/WETH pool
    
    * Add withdraw test
    
    * prettier
    
    * remove .only in fork tests
    
    ---------
    
    Co-authored-by: Shahul Hameed <[email protected]>
    naddison36 and shahthepro authored Jul 31, 2023
    Configuration menu
    Copy the full SHA
    75329db View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Configuration menu
    Copy the full SHA
    ea68019 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5607b5d View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. [ DFD-1 ] Balancer's checkBalance (#1730)

    * add alternative implementation of Balancer's checkBalance
    
    * correct the checkBalance implementation
    sparrowDom authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    012a83d View commit details
    Browse the repository at this point in the history
  2. Balancer fork tests (#1727)

    * Added large withdraw tests for Balancer strategy
    
    * fix test log
    
    * Balancer withdraw to handle close to BPT limit
    
    * Small change to Balancer withdraw fork test
    
    * add some comments
    
    * change implementation
    
    ---------
    
    Co-authored-by: Domen Grabec <[email protected]>
    naddison36 and sparrowDom authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    b120330 View commit details
    Browse the repository at this point in the history
  3. Add read-only reentrancy test (#1731)

    * Added large withdraw tests for Balancer strategy
    
    * fix test log
    
    * Balancer withdraw to handle close to BPT limit
    
    * Small change to Balancer withdraw fork test
    
    * add some comments
    
    * Add test for read-only reentrancy
    
    * add reentrancy protection to checkBalance functions
    
    * add documentation
    
    * remove the only
    
    ---------
    
    Co-authored-by: Nicholas Addison <[email protected]>
    Co-authored-by: Domen Grabec <[email protected]>
    3 people authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    39a7b3f View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Balancer fixes (#1734)

    * prettier
    
    * adjust how checkBalance is calculated
    sparrowDom authored Aug 3, 2023
    Configuration menu
    Copy the full SHA
    346d949 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2023

  1. Balancer withdrawal fix (#1739)

    * fix balancer withdrawals
    
    * lint
    
    * prettier
    sparrowDom authored Aug 5, 2023
    Configuration menu
    Copy the full SHA
    fbafb80 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    430fbad View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3ec984c View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2023

  1. Configuration menu
    Copy the full SHA
    ecceeb1 View commit details
    Browse the repository at this point in the history
  2. bug fix

    sparrowDom committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    eb11498 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Configuration menu
    Copy the full SHA
    a25a661 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b9dd480 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Configuration menu
    Copy the full SHA
    3af8527 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. fix re-entrancy test

    sparrowDom committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    3767bb2 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Configuration menu
    Copy the full SHA
    3cdbdba View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. fixture fix

    sparrowDom committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    c69369e View commit details
    Browse the repository at this point in the history
  2. bug fix

    sparrowDom committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    8a26a4e View commit details
    Browse the repository at this point in the history
  3. prettier

    sparrowDom committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    afb2d67 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3ae0892 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Configuration menu
    Copy the full SHA
    b321712 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. L02 improve naming (#1783)

    * improve naming
    
    * one more rename
    
    * buf fix
    sparrowDom authored Aug 28, 2023
    Configuration menu
    Copy the full SHA
    34608a7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a323447 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7d8c3fa View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d4eef49 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. fix renaming bug

    sparrowDom committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    4d36852 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. Configuration menu
    Copy the full SHA
    d206ce4 View commit details
    Browse the repository at this point in the history
  2. prettier

    sparrowDom committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    b127355 View commit details
    Browse the repository at this point in the history
  3. M04 - minBptFunction robustness (#1795)

    * change bptExpected to ignore Oracle prices and assume assets are always pegged. (Vault value checker shall be used to mitigate issues with said assumption)
    
    * fix all the tests
    
    * add test for pool manipulation
    
    * prettier & lint
    
    * minor change
    
    * add withdrawal test
    
    * update documentation
    
    * pick string error length that is smaller than 32 characters
    
    * prettier
    
    * correct comment
    
    * better comments
    
    * prettier
    sparrowDom authored Aug 30, 2023
    Configuration menu
    Copy the full SHA
    6ad405c View commit details
    Browse the repository at this point in the history
  4. M02 withdrawal fuzzing tests (#1801)

    * add more withdrawal tests
    
    * add more withdrawal cases
    sparrowDom authored Aug 30, 2023
    Configuration menu
    Copy the full SHA
    04b3010 View commit details
    Browse the repository at this point in the history
  5. N02 gas inefficiencies (#1786)

    * gas optimisation
    
    * fix bad merge and prettier
    sparrowDom authored Aug 30, 2023
    Configuration menu
    Copy the full SHA
    852afa4 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    abf482f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d159fbe View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e09a9b9 View commit details
    Browse the repository at this point in the history
  9. fix typo (#1798)

    sparrowDom authored Aug 30, 2023
    Configuration menu
    Copy the full SHA
    daeab91 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    a2f8fcd View commit details
    Browse the repository at this point in the history
  11. M03 - missing or misleading documentation (#1781)

    * improve documentation
    
    * add comma
    sparrowDom authored Aug 30, 2023
    Configuration menu
    Copy the full SHA
    cf4122a View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. M01 More comprehensive test suite (#1780)

    * add tests for approving tokens and harvesting rewards
    
    * prettier and lint
    sparrowDom authored Aug 31, 2023
    Configuration menu
    Copy the full SHA
    fcc08f7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5a338d6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d2c0039 View commit details
    Browse the repository at this point in the history
  4. remove only

    sparrowDom committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    70b4481 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    71332e5 View commit details
    Browse the repository at this point in the history
  6. lint

    sparrowDom committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    900e6d0 View commit details
    Browse the repository at this point in the history
  7. fix unit tests

    sparrowDom committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    38a7e86 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    3fd8f23 View commit details
    Browse the repository at this point in the history
  9. remove console log

    sparrowDom committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    88bfd30 View commit details
    Browse the repository at this point in the history
  10. improve checkBalance test by testing that checkBalance amount doesn't…

    … decrease after the attack comaring to the middle of the attack.
    sparrowDom committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    b7e0dc3 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. confirm that yield gained by 3rd party tilting the pool can be extrac…

    …ted by withdrawing the funds
    sparrowDom committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    a0cb919 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Configuration menu
    Copy the full SHA
    0f02fad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e95315a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3019b49 View commit details
    Browse the repository at this point in the history
  4. bug fix

    sparrowDom committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    6b5a2b4 View commit details
    Browse the repository at this point in the history
  5. bug fix

    sparrowDom committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    09684fd View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Configuration menu
    Copy the full SHA
    c1e1cf2 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Configuration menu
    Copy the full SHA
    23b8570 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. intermediary work

    sparrowDom committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    73a26e0 View commit details
    Browse the repository at this point in the history