Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Dripper duration. #2125

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions contracts/deploy/mainnet/101_dripper_fourteen_day.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
const { deploymentWithGovernanceProposal } = require("../../utils/deploy");

module.exports = deploymentWithGovernanceProposal(
{
deployName: "101_dripper_fourteen_day",
forceDeploy: false,
// forceSkip: true,
// onlyOnFork: true, // this is only executed in forked environment
// reduceQueueTime: true, // just to solve the issue of later active proposals failing
// proposalId:
// "107146116537515525680409743691006652841112781786145428928245504968702148742130",
},
async ({ ethers }) => {
// Current contracts
const cOETHDripperProxy = await ethers.getContract("OETHDripperProxy");
const cOETHDripper = await ethers.getContractAt(
"OETHDripper",
cOETHDripperProxy.address
);
const cOETHVaultProxy = await ethers.getContract("OETHVaultProxy");
const cOETHVault = await ethers.getContractAt(
"OETHVaultCore",
cOETHVaultProxy.address
);

// Governance Actions
// ----------------
return {
name: "Increase OETH Dripper Time\n\
\n\
Change the OETH dripper time from 7 to 14 days.\n\
\n\
The OETH dripper's duration was set to 7 days last January to increase flow of funds from the dripper to OETH.\
However, to adapt to the beacon chain sweep delay (approx 9 days), we can increase the duration to match beacon chain specification.\
",
actions: [
{
contract: cOETHDripper,
signature: "setDripDuration(uint256)",
args: [14 * 24 * 60 * 60],
},
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think a rebase is necessary. Any reason for adding that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reused the PR that decreased the dripper duration. I thought that it was good to rebase right after changing the dripper duration because the vault will receive a fresh token, and this ensures a smoother APY.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha

contract: cOETHVault,
signature: "rebase()",
args: [],
},
],
};
}
);
Loading