Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support xclim 0.53.1 #482

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Support xclim 0.53.1 #482

wants to merge 7 commits into from

Conversation

RondeauG
Copy link
Collaborator

@RondeauG RondeauG commented Oct 24, 2024 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • This PR does not seem to break the templates.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Bumps xclim to the latest version.
  • Fixes a bug in change_units.
  • Removes calls to xclim.ensemble.change_significance.

Does this PR introduce a breaking change?

Other information:

aulemahal
aulemahal approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ds.assign returns a new Dataset, the idea is to update what "ds" makes reference too within the local context of the function.

src/xscen/utils.py Outdated Show resolved Hide resolved
src/xscen/utils.py Outdated Show resolved Hide resolved
src/xscen/utils.py Outdated Show resolved Hide resolved
src/xscen/utils.py Outdated Show resolved Hide resolved
RondeauG and others added 4 commits October 24, 2024 12:19
@RondeauG @aulemahal
Update src/xscen/utils.py
7ab9b1e 
Co-authored-by: Pascal Bourgault <[email protected]>
@RondeauG @aulemahal
Update src/xscen/utils.py
bcd63e2 
Co-authored-by: Pascal Bourgault <[email protected]>
@RondeauG @aulemahal
Update src/xscen/utils.py
0b1c212 
Co-authored-by: Pascal Bourgault <[email protected]>
@RondeauG @aulemahal
Update src/xscen/utils.py
444cdd0 
Co-authored-by: Pascal Bourgault <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre approved these changes

@aulemahal aulemahal aulemahal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

⚠️ Nightly upstream-dev CI failed ⚠️
3 participants
@RondeauG @Zeitsperre @aulemahal