[#10] Detekt Integration and fixing existing errors (#39)

build.gradle.kts

@@ -1,9 +1,12 @@
+import io.gitlab.arturbosch.detekt.Detekt
+
 plugins {
     libs.plugins.apply {
         alias(jetbrainsCompose) apply false
         alias(androidApplication) apply false
         alias(kotlinMultiplatform) apply false
         alias(kover)
+        alias(detekt)
     }
 }
 
@@ -30,6 +33,37 @@ allprojects {
         }
     }
 
+    apply(plugin = rootProject.libs.plugins.detekt.get().pluginId).also {
+        detekt {
+            buildUponDefaultConfig = true
+            allRules = true
+            parallel = true
+            config.from("${rootProject.projectDir}/detekt.yml")
+        }
+        tasks.withType<Detekt> {
+            setSource(files(project.projectDir))
+            exclude("**/build/**")
+            exclude {
+                it.file.relativeTo(projectDir).startsWith(
+                    project.layout.buildDirectory.asFile.get().relativeTo(projectDir)
+                )
+            }
+        }.onEach { detekt ->
+            // skip detekt tasks unless a it is specifically called
+            detekt.onlyIf {
+                gradle.startParameter.taskNames.any { it.contains("detekt") }
+            }
+        }
+
+        tasks.register("detektAll") {
+            dependsOn(tasks.withType<Detekt>())
+        }
+
+        dependencies {
+            detektPlugins(rootProject.libs.common.detektFormatting)
+        }
+    }
+
     // todo CMP bug needs to be removed when fixed
     // https://youtrack.jetbrains.com/issue/KT-41821/Kotlin-1.4.10-ios-target-java.lang.IllegalStateException-failed-to-resolve-Kotlin-library-org.jetbrains.kotlinx-atomicfu-common
     apply(plugin = rootProject.libs.plugins.atomicfu.get().pluginId)

composeApp/build.gradle.kts

@@ -32,6 +32,7 @@ kotlin {
         }
     }
 
+    @Suppress("UnusedPrivateProperty")
     sourceSets {
         val androidMain by getting {
             dependencies {
@@ -97,4 +98,3 @@ android {
         debugImplementation(libs.android.composeUiTooling)
     }
 }
-

composeApp/src/androidMain/kotlin/com/oztechan/tracefit/MainActivity.kt

@@ -21,4 +21,4 @@ class MainActivity : ComponentActivity() {
 @Composable
 fun AppAndroidPreview() {
     App()
-}
+}

composeApp/src/commonMain/kotlin/App.kt

@@ -36,4 +36,4 @@ fun App() {
             }
         }
     }
-}
+}

composeApp/src/commonMain/kotlin/Shared.kt

@@ -1 +1 @@
-val GREETING = "Hello World!"
+const val GREETING = "Hello World!"

composeApp/src/iosMain/kotlin/MainViewController.kt

@@ -1,3 +1,4 @@
 import androidx.compose.ui.window.ComposeUIViewController
 
+@Suppress("unused", "FunctionNaming") // used in iOS
 fun MainViewController() = ComposeUIViewController { App() }

gradle/libs.versions.toml

@@ -1,6 +1,7 @@
 [versions]
 kotlin = "1.9.10"
 atomicfu = "0.17.3"
+detekt = "1.23.3"
 kover = "0.6.1"
 compose = "1.5.4"
 jetbrainsCompose = "1.5.3"
@@ -12,6 +13,7 @@ androidx-activityCompose = "1.8.0"
 # COMMON
 kotlin-test = { module = "org.jetbrains.kotlin:kotlin-test", version.ref = "kotlin" }
 common-ComposeCompiler = { module = "androidx.compose.compiler:compiler", version.ref = "composeCompiler" } # Workaround for compose compiler update
+common-detektFormatting = { module = "io.gitlab.arturbosch.detekt:detekt-formatting", version.ref = "detekt" }
 
 # ANDROID
 android-activityCompose = { module = "androidx.activity:activity-compose", version.ref = "androidx-activityCompose" }
@@ -28,3 +30,4 @@ androidApplication = { id = "com.android.application", version.ref = "androidGra
 kotlinMultiplatform = { id = "org.jetbrains.kotlin.multiplatform", version.ref = "kotlin" }
 atomicfu = { id = "kotlinx-atomicfu" }
 kover = { id = "org.jetbrains.kotlinx.kover", version.ref = "kover" }
+detekt = { id = "io.gitlab.arturbosch.detekt", version.ref = "detekt" }

settings.gradle.kts

@@ -11,11 +11,12 @@ pluginManagement {
 }
 
 dependencyResolutionManagement {
+    @Suppress("UnstableApiUsage")
     repositories {
         google()
         mavenCentral()
         maven("https://maven.pkg.jetbrains.space/public/p/compose/dev")
     }
 }
 
-include(":composeApp")
+include(":composeApp")