Fix 'stuck' database inputs #402
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add meaningful exception when populating step parameters
Bump query-string from 8.2.0 to 9.0.0 in /src/Moryx.CommandCenter.Web
seveneleven
requested review from
MathoMathiasCamara,
jsonBackup and
1nf0rmagician
| @@ -101,8 +101,10 @@ class DatabaseModel extends React.Component<DatabaseModelPropsModel & DatabaseMo | |||
| } | |||
|
|
|||
| public onInputChanged(e: React.FormEvent<HTMLInputElement>, entryName: string): void { | |||
| console.log(`${entryName}: ${(e.target as HTMLSelectElement).value}`) | |||
There was a problem hiding this comment.
Do you want to leave the log in here? 🤔
src/Moryx.CommandCenter.Web/src/common/components/Menu/RoutingMenuItem.tsx
Show resolved
Hide resolved
|
Ahh, the fixes need to be done for release 6 as well 🙈 |
* `npm run dev` did not succeed anymore, so the `contentBase` needed to be changed to `static`. * Deprecated `--watch` option is now removed from `dev` script.
The previous version could mark multiple list items as active if they were similar (starting with same string). Now, the path is checked for being a sub path, rather than just starting with the same string.
Input config values seemed to be stuck, when clicking through several database contexts. Now the values get updated properly.
seveneleven
force-pushed
the
bugfix/stuck-database-inputs
branch
from
2b35e04
to
9df112b
Compare
|
Is this issue resolved by #405 or should it be rebased and proceed on release/6? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Input fields of database connection switch properly now, when clicking throug database contexts.
When reviewing, it would be greate if you could test that this fix didn't break anything else.