Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TemplateProcessor] Fix 0 considered as empty string #2617

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[TemplateProcessor] Fix 0 considered as empty string #2617

wants to merge 3 commits into from
+3 −1

Conversation

cavasinf
Copy link

@cavasinf cavasinf commented May 30, 2024 •
edited
Loading

Description

Fixes #2572

Checklist:

  • My CI is 🟢
  • I have covered by unit tests my new code (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes
  • I have updated the changelog

@coveralls
Copy link

coveralls commented May 30, 2024 •
edited
Loading

Coverage Status

coverage: 96.918%. remained the same
when pulling c6a9569 on cavasinf:patch-1
into feadceb on PHPOffice:master.

@adriansuter
Copy link

👍 Ready to be merged.

@Progi1984
Copy link
Member

@cavasinf Could you update the changelog, please ?

@Progi1984 Progi1984 added the Status: Waiting for feedback Question has been asked, waiting for response from PR author label Aug 7, 2024
@dsuurlant
Copy link

We are running into this issue and it would be great to see this fix merged!

@cavasinf
Copy link
Author

cavasinf commented Oct 14, 2024 •
edited
Loading

Sorry for the delay!
@Progi1984 I've added it to the BC Breaks part, as it will certainly change the behavior on other devs processor result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Waiting for feedback Question has been asked, waiting for response from PR author
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TemplateProcessor.php print empty '' string if value is 0
5 participants
@cavasinf @coveralls @adriansuter @Progi1984 @dsuurlant