feat: add support for rowspan in addHTML() #2643
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Progi1984
requested changes
Aug 7, 2024
| Html::addHtml($section, $html); | ||
|
|
||
| $doc = TestHelperDOCX::getDocument($phpWord, 'Word2007'); | ||
| self::assertTrue($doc->elementExists('/w:document/w:body/w:tbl')); |
There was a problem hiding this comment.
@jnlin Could you add more assertions for checking the colspan and the rowspan ?
| @@ -6,6 +6,7 @@ | |||
|
|
|||
| - IOFactory : Added extractVariables method to extract variables from a document [@sibalonat](https://github.com/sibalonat) in [#2515](https://github.com/PHPOffice/PHPWord/pull/2515) | |||
| - PDF Writer : Documented how to specify a PDF renderer, when working with the PDF writer, as well as the three available choices by [@settermjd](https://github.com/settermjd) in [#2642](https://github.com/PHPOffice/PHPWord/pull/2642) | |||
| - HTML Parser : Added support for rowspan in add HTML [#1643](https://github.com/PHPOffice/PHPWord/issues/1643) | |||
There was a problem hiding this comment.
@jnlin Could you add you as author ?
| if (!empty($rowspan)) { | ||
| $cellStyles['vMerge'] = 'restart'; | ||
| } | ||
| $beforespan = $node->getAttribute('beforespan'); |
There was a problem hiding this comment.
This attribute doesn't exist. Can you use a Real attribute or an another method ?
| $afterspan = $node->getAttribute('afterspan'); | ||
| if (!empty($afterspan)) { | ||
| $cellRowContinue = ['vMerge' => 'continue']; | ||
| $aftercolspan = $node->getAttribute('aftercolspan'); |
There was a problem hiding this comment.
This attribute doesn't exist. Can you use a Real attribute or an another method ?
Progi1984
added
the
Status: Waiting for feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves #1643 . Thanks for @yherus for the initial code
Checklist: