Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move variables to ELF sections with mangled names #1198

Merged
merged 4 commits into from
Jun 12, 2024
Merged

Move variables to ELF sections with mangled names #1198

merged 4 commits into from
Jun 12, 2024

Conversation

CohenArthur
Copy link
Contributor

Add the same logic as #1160 but for global variables

@CohenArthur CohenArthur mentioned this pull request Apr 10, 2024
Merged
riederm
riederm previously requested changes Apr 11, 2024
View reviewed changes
src/codegen/generators/variable_generator.rs Outdated Show resolved Hide resolved
@CohenArthur
Copy link
Contributor Author

The CI test failure is extremely weird!

fatal runtime error: failed to initiate panic, error 5
error: test failed, to rerun pass `-p iec61131std --test string_function_tests`

I can't reproduce it locally when running the workflow's command (./scripts/build.sh --test). I think it might just be a github actions blurp and it just needs a rerun?

@CohenArthur CohenArthur mentioned this pull request Apr 18, 2024
Merged
@volsa
Copy link
Member

volsa commented Apr 18, 2024

I can't reproduce it locally when running the workflow's command (./scripts/build.sh --test). I think it might just be a github actions blurp and it just needs a rerun?

Yup, for some reason this happens occasionally. I've triggered a re-run which should hopefully fix the issue.

@CohenArthur
Copy link
Contributor Author

thanks @volsa ! it did :D

ghaith
ghaith previously approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@ghaith ghaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Sorry for the delay in reviewing. =)
Since @riederm has already been changed i'll go ahead and approve it.

@CohenArthur
Copy link
Contributor Author

Rebased and updated the test snapshots

@ghaith ghaith dismissed riederm’s stale review June 12, 2024 16:42

Already fixed

@ghaith ghaith merged commit 92e586a into PLC-lang:master Jun 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghaith ghaith ghaith approved these changes

@riederm riederm riederm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CohenArthur @volsa @ghaith @riederm