refactor(AST): introduce AstVisitor trait #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riederm
force-pushed
the
mari/ast_visitor
branch
2 times, most recently
from
6d6a228
to
ebae171
Compare
The AST-Visitor trait allows generic visiting of AST-nodes. A default Walking behavior is implemented for each AstStatement but it can be altered by any implementor. When overriding a visit_XXX method, the implementation can decide to continue with the default walking behavior (by calling the walk function on the passed AstStatement-Struct, to skip it, or to continue with an alternative walking bahavior.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1231 +/- ##
==========================================
- Coverage 95.62% 90.88% -4.74%
==========================================
Files 150 154 +4
Lines 42657 45149 +2492
==========================================
+ Hits 40789 41033 +244
- Misses 1868 4116 +2248 ☔ View full report in Codecov by Sentry. |
the visitor can now be called on the CompilationUnit and it will visit all GlobalVariables, all Pous, all UserTypes and Implementations
removed unused AST element CastStatement
|
I improved the code coverage quite a bit, I think the codecov comment above (64.9%) is outdated. |
ghaith
reviewed
Jun 10, 2024
volsa
reviewed
Jun 10, 2024
ghaith
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AST-Visitor trait allows generic visiting of AST-nodes. A default Walking behavior is implemented for each AstStatement but it can be altered by any implementor. When overriding a visit_XXX method, the implementation can decide to continue with the default walking behavior (by calling the walk function on the passed AstStatement-Struct, to skip it, or to continue with an alternative walking bahavior.
The code could be improved with a derive-macro for the walker trait