Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introduce TO_<NUM> functions #1338

Merged
merged 2 commits into from
Oct 18, 2024
Merged

feat: Introduce TO_<NUM> functions #1338

merged 2 commits into from
Oct 18, 2024

Conversation

volsa
Copy link
Member

@volsa volsa commented Oct 17, 2024

This commit introduces the TO_<NUM> library functions, which make use of the already existing and tested <NUM>_TO_<NUM> library functions.

Note: Functions for string, bit / byte datatypes (BIT, BOOL, BYTE, WORD, DWORD, LWORD) and date / time (TIME, LTIME, DATE, LDATE, DT, LDT, TOD, LTOD) will be handled in another PR.

This commit introduces the `TO_<NUM>` library functions, which under the
hood use the already exisiting and tested `<NUM>_TO_<NUM>` library functions.
@volsa volsa requested review from ghaith and mhasel October 17, 2024 07:50
@volsa volsa changed the title feat: Introduce TO_<NUM> library functions feat: Introduce TO_<NUM> functions Oct 17, 2024
@mhasel
Copy link
Member

mhasel commented Oct 18, 2024

One more thought about the python scripts - the stdlib headers is something we deliver, so I'm still not sure if we want to keep these together in the same folder. I'm fine with keeping them in our sources, but honestly I'd prefer them to be in a separate location. It feels more like an internal dev-tool than something we should/want to include in our stdlib package.

You can merge this commit as it is now, we can discuss this further and move the files in another commit if necessary.

@volsa volsa merged commit 7a50845 into master Oct 18, 2024
19 checks passed
@volsa volsa deleted the volsa/to_num branch October 18, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants