forked from rsim/oracle-enhanced
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/v1.6.2.1 #3
Open
riyengar8
wants to merge
230
commits into
master
Choose a base branch
from
feature/v1.6.2.1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit supports following changes, still it needs to support date/time features such as `set_date_columns` - BindSubstitution class removed rails/rails@ee54e9b#diff-c226a4680f86689c3c170d4bc5911e96 - Delegate `Column#type` to the injected type object rails/rails@0b682e4
Initial support for Rails 4.2
rails42:Support _field_changed argument changes
Refer rails/rails@6da0072 It has not supported `table_name_prefix` and `table_name_suffix` yet.
…thod_removed ActiveRecord::Migrator.proper_table_name has been removed from Rails
Rails4.2 Add new_column method
Column#primary method removed from Rails
`ActiveRecord::ConnectionAdapters::Type::Value` to `ActiveRecord::Type::Value`
Rails 4.2 Types namespace moved
Rails4.2 Rename type_cast to type_cast_from_database
…ase' for nil:NilClass
Rails4.2 Use quote_value method to avoid undefined method `type_cast_for_database' for nil:NilClass
Detail can be found here: rails/rails@d44702e So writing a CLOB column might causing error in 4.2 beta 1. Looks we don't need this check any longer, simply check it against String type might do the job.
text? has been removed from Column class
…acle_enhanced Rails4.2 Support to work with Rails foreien_key implementation
DEPRECATION WARNING: `timestamp` was called without specifying an option for `null`. In Rails 5.0, this behavior will change to `null: false`. You should manually specify `null: true` to prevent the behavior of your existing migrations
…explicitly Add `null: true` to avoid DEPRECATION WARNING
Rails4.2 Support NCHAR correctly
…column_name Rails4.2 Support OracleEnhancedAdapter.emulate_integers_by_column_name
Update history for v1.6.0
Requires activerecord 4.2.1 or higher
Update matcher to skip sql statements to get `table` metadata
Update Ruby version
Fix serialized value becomes from yaml to string once saved
Update readme for v1.6
Update history for v1.6.1
due to it causes ORA-00904 reported in rsim#662 Note: This attribute cannot be referenced by foreign key since it requires unique constraints created.
Unique constraints not created when function unique index created
create_table should use default tablespace values for lobs
…_activemodel Requires activerecord 4.2.1 or higher, not activemodel
Update history for v1.6.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess this branch is what we used to build the v1.6.2.1 of this that we are using in SOS-API. Assuming that's the case, I reckon this should be merged to master and tagged. Let me know if you disagree. Feel free to assign this back to me if you want me to do the gruntwork; just thought you might want to see it first before I go for it.