Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch_int -> from_integer; integer_representation -> to_integer #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mkannwischer
Copy link
Contributor

sage deprecated fetch_int and integer_representation in vesion 3.9: https://www.sagemath.org/changelogs/sage-9.8.txt.

I'm getting the following warning when running our code

/usr/lib/python3.12/site-packages/sage/structure/sequence.py:233: DeprecationWarning: fetch_int is deprecated. Please use from_integer instead.
See https://github.com/sagemath/sage/issues/33941 for details.
  x = list(x)  # make a copy even if x is a list, we're going to change it
/tmp/MAYO-sage/sagelib/utilities.py:29: DeprecationWarning: integer_representation is deprecated. Please use to_integer instead.
See https://github.com/sagemath/sage/issues/33941 for details.
  bs += [v[i*_sage_const_2 ].integer_representation() |
/tmp/MAYO-sage/sagelib/utilities.py:30: DeprecationWarning: integer_representation is deprecated. Please use to_integer instead.
See https://github.com/sagemath/sage/issues/33941 for details.

We should switch to from_integer to_integer.
Thanks yx7

sage deprecated fetch_int and integer_representation in vesion 3.9:
https://www.sagemath.org/changelogs/sage-9.8.txt.

We should switch to from_integer to_integer.
Thanks yx7
@mkannwischer
Copy link
Contributor Author

Uff - this breaks on still fairly recent sage versions (9.5 in CI) - let's not change this yet.

@claucece
Copy link
Member

Let's wait on this one, yes. Let me see if I find the plans to upgrade the CI version..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants