Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sticky donate link button #485

Open
wants to merge 2 commits into
base: wordpress
Choose a base branch
from
Open

Sticky donate link button #485

wants to merge 2 commits into from

Conversation

rpeterman-gp
Copy link
Contributor

@rpeterman-gp rpeterman-gp commented Oct 7, 2024 •
edited by brandonhundt
Loading

  • Makes donation link in header nav "sticky" to page in browsers that support CSS animation-timeline.

To Review

  • Use the Preview link located in the Now comment below.

...or...

  • Checkout Branch.
  • Run yarn.
  • Run yarn dev.
  • In Chromium browser, go to localhost:3000.

...then...

  • Scroll the page and ensure donate button becomes fixed to top of page shortly after it scrolls out of view.
  • Open in Firefox and Safari. Donate button should not become sticky. They do not support css animation-timeline yet.

@brandonhundt
Copy link
Collaborator

@rpeterman-gp I like it on desktop, not so much for mobile. I think it lacks too much context for mobile to have a random heart floating.

Idea... Should we stick the button to the lower right (Like a Fob)? And keep the word "donate" for the mobile button?

brandonhundt
brandonhundt requested changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@brandonhundt brandonhundt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See previous comment. Thanks Rick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonhundt brandonhundt brandonhundt requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpeterman-gp @brandonhundt