Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove storage when recompute using saved_tensor_hooks #70455

Merged
merged 2 commits into from
Dec 26, 2024
Merged

Remove storage when recompute using saved_tensor_hooks #70455

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2eac379
Remove storage when recompute using saved_tensor_hooks
sneaxiy Dec 25, 2024
8db6b07
refine codes
sneaxiy Dec 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions python/paddle/distributed/fleet/recompute/recompute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ def inner_unpack(inner_x):
with paddle.autograd.saved_tensors_hooks(
inner_pack, inner_unpack
):
unused_outputs = function(*args, **kwargs)
function(*args, **kwargs)
else:
with paddle.set_grad_enabled(True), paddle.amp.auto_cast(
enable=is_fw_autocast,
Expand All @@ -441,14 +441,14 @@ def inner_unpack(inner_x):
), paddle.autograd.saved_tensors_hooks(
inner_pack, inner_unpack
):
unused_outputs = function(*args, **kwargs)
function(*args, **kwargs)

if x not in storage:
raise Exception(
"Not supported to retrieve a tensor saved by autograd multiple times that is no need to recompute."
)

return storage[x]
return storage.pop(x)

with paddle.autograd.saved_tensors_hooks(pack, unpack):
outputs = function(*args, **kwargs)
Expand Down
Loading