Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump deps to work with backstage v1.29.0 #73

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Conversation

jpd4emis
Copy link
Contributor

@jpd4emis jpd4emis commented Jul 22, 2024

Description

Bump the dependencies to clear warnings in updating to backstage v1.29.0

Issue number: #74

Type of change

  • New feature (non-breaking change which adds functionality)
  • Fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented
  • Changes generate no new warnings
  • PR title follows conventional commit semantics

If this is a breaking change 👇

  • I have documented the migration process
  • I have implemented necessary warnings (if it can live side by side)

Acknowledgement

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@t1agob t1agob linked an issue Jul 23, 2024 that may be closed by this pull request
@t1agob t1agob changed the base branch from main to next July 23, 2024 21:50
@t1agob
Copy link
Contributor

t1agob commented Jul 23, 2024

Hello @jpd4emis! Thanks for creating a PR for this one. Although it wasn't breaking anything I like to keep things clean. Thanks for supporting us on that. I took this opportunity to update to the latest versions as some packages already had new releases.

I have tested locally and I confirm there are no changes in behaviour. I'll merge this and add the details to the release notes once I release it later today.

@t1agob t1agob marked this pull request as ready for review July 23, 2024 21:51
@t1agob t1agob self-requested a review as a code owner July 23, 2024 21:51
@t1agob t1agob self-assigned this Jul 23, 2024
Copy link
Contributor

@t1agob t1agob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the new versions and everything works.

@t1agob t1agob merged commit 49adf3b into PagerDuty:next Jul 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating to Backstage v1.29.0 reports deduplicated issue
2 participants