Fix code scanning alert no. 117: Incomplete string escaping or encoding #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/PagerDuty/pd-live-react/security/code-scanning/117
To fix the problem, we need to ensure that all special characters, including backslashes, are properly escaped in the
expressionstring. The best way to achieve this is to use a well-tested library for escaping CSS selectors, such ascssesc. This library handles all necessary escaping and ensures that the resulting string is safe to use in a CSS selector.cssesclibrary.cssesclibrary in the file.cssescfunction to handle all necessary escaping.Suggested fixes powered by Copilot Autofix. Review carefully before merging.