Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge in changes from version 1.7.3 #174

Merged
merged 20 commits into from
Mar 27, 2024
Merged

Merge in changes from version 1.7.3 #174

merged 20 commits into from
Mar 27, 2024

Conversation

hcopperm
Copy link
Contributor

@hcopperm hcopperm commented Mar 20, 2024

#153 was released but never merged. this pr currently includes the changes from #171 as well.

Original description from pr 171:

Description

We learned that a recent cert upgrade caused problems for some people who use pdagent. The changes in this pr accomplish the following

  • Certs are updated
  • Both the ubuntu and centos builds now run
  • If people want to run builds inside Docker (which does not support systemd although it technically exists), there is now a way to specify the correct option so that the packages can be Docker-compatible
  • Documentation is updated
  • Update version number
  • Update tests so that they run in python3 (remove throttling testing)

Original description from pr 153:

Notably this should help resolve:

The additions/deletions from pd-queue, pd-send and their *.py iterations are mostly just a copy, with a minor change in pd-queue to leverage six's iteritems.

@joshwertheim
Copy link

Quick suggestion, can we add a user-agent to our urllib requests? Something like: https://stackoverflow.com/a/24226797

This way we can start tracking usage once this is finally deployed/released.

@hcopperm hcopperm marked this pull request as ready for review March 25, 2024 20:49
@hcopperm
Copy link
Contributor Author

Quick suggestion, can we add a user-agent to our urllib requests? Something like: https://stackoverflow.com/a/24226797

This way we can start tracking usage once this is finally deployed/released.

urg despite the fact that this is a very good idea i'm gonna leave it for if we end up investing more into pdagent

Copy link

@blagh blagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link

@joshwertheim joshwertheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hcopperm hcopperm merged commit c7ca316 into master Mar 27, 2024
4 checks passed
@hcopperm hcopperm deleted the merge-173-changes branch March 27, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants