fix(panos_static_route): invalid nexthop for none value #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change also requires an update on pan-os-python to accept 'none' value for the nexthop type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue with
"none"value fornexthop_typeinpanos_static_route.This change also requires pan-os-python to accept 'none' value for the nexthop type, proposed on the following PR:
PaloAltoNetworks/pan-os-python#578
Motivation and Context
With the recent change in pan-os-ansible, it fetches default values from pan-os-python sdk while creating or updating objects with None value params. In the existing implementation "none" string value was converted to
Nonein the module and fetching default value from pan-os-python sdk (which is 'ip-address') for this lead to a invalid config.With this change "none" string value is passed as-is to the pan-os-python and it is also proposed to accept "none" value for the nexthop type in the linked PR.
Fixes #584
How Has This Been Tested?
Tested live on VMSeries firewalls and Panorama.
Types of changes
Checklist