Skip to content

github, hangar, jenkins, fabric, curserinth #79

github, hangar, jenkins, fabric, curserinth

github, hangar, jenkins, fabric, curserinth #79

GitHub Actions / clippy failed Sep 17, 2023 in 1s

clippy

30 errors, 5 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 30
Warning 5
Note 0
Help 0

Versions

  • rustc 1.72.0 (5680fa18f 2023-08-23)
  • cargo 1.72.0 (103a7ff2e 2023-08-15)
  • clippy 0.1.72 (5680fa1 2023-08-23)

Annotations

Check warning on line 9 in src/util/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `Context`

warning: unused import: `Context`
 --> src/util/mod.rs:9:14
  |
9 | use anyhow::{Context, Result};
  |              ^^^^^^^

Check warning on line 27 in src/util/mrpack.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `Source`

warning: unused import: `Source`
  --> src/util/mrpack.rs:27:5
   |
27 |     Source,
   |     ^^^^^^

Check warning on line 10 in src/util/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `futures::StreamExt`

warning: unused import: `futures::StreamExt`
  --> src/util/mod.rs:10:5
   |
10 | use futures::StreamExt;
   |     ^^^^^^^^^^^^^^^^^^

Check failure on line 478 in src/model/servertype/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

no method named `get_filename` found for reference `&model::downloadable::Downloadable` in the current scope

error[E0599]: no method named `get_filename` found for reference `&model::downloadable::Downloadable` in the current scope
   --> src/model/servertype/mod.rs:478:51
    |
478 |             Self::Downloadable { inner } => inner.get_filename(server, client).await,
    |                                                   ^^^^^^^^^^^^ help: there is a method with a similar name: `get_type_name`

Check failure on line 392 in src/model/servertype/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

no method named `download` found for reference `&model::downloadable::Downloadable` in the current scope

error[E0599]: no method named `download` found for reference `&model::downloadable::Downloadable` in the current scope
   --> src/model/servertype/mod.rs:392:51
    |
392 |             Self::Downloadable { inner } => inner.download(server, client).await,
    |                                                   ^^^^^^^^ method not found in `&Downloadable`

Check failure on line 378 in src/model/servertype/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

no method named `download` found for enum `model::downloadable::Downloadable` in the current scope

error[E0599]: no method named `download` found for enum `model::downloadable::Downloadable` in the current scope
   --> src/model/servertype/mod.rs:378:33
    |
378 |                 Ok(buildtools().download(server, client).await?)
    |                                 ^^^^^^^^ method not found in `Downloadable`
    |
   ::: src/model/downloadable/mod.rs:23:1
    |
23  | pub enum Downloadable {
    | --------------------- method `download` not found for this enum

Check failure on line 376 in src/model/servertype/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

no method named `download` found for enum `model::downloadable::Downloadable` in the current scope

error[E0599]: no method named `download` found for enum `model::downloadable::Downloadable` in the current scope
   --> src/model/servertype/mod.rs:376:52
    |
376 |             Self::BungeeCord {} => Ok(bungeecord().download(server, client).await?),
    |                                                    ^^^^^^^^ method not found in `Downloadable`
    |
   ::: src/model/downloadable/mod.rs:23:1
    |
23  | pub enum Downloadable {
    | --------------------- method `download` not found for this enum

Check failure on line 160 in src/sources/jenkins.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

mismatched types

error[E0308]: mismatched types
   --> src/sources/jenkins.rs:160:9
    |
160 |     let (build_url, _, relative_path, _build_number) =
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected a tuple with 5 elements, found one with 4 elements
161 |         get_jenkins_filename(client, url, job, build, artifact).await?;
    |         -------------------------------------------------------------- this expression has type `(std::string::String, std::string::String, std::string::String, i64, std::option::Option<std::string::String>)`
    |
    = note: expected tuple `(std::string::String, std::string::String, std::string::String, i64, std::option::Option<std::string::String>)`
               found tuple `(_, _, _, _)`

Check failure on line 342 in src/model/servertype/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

not all trait items implemented, missing: `resolve_source`

error[E0046]: not all trait items implemented, missing: `resolve_source`
   --> src/model/servertype/mod.rs:342:1
    |
342 |   impl Source for ServerType {
    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `resolve_source` in implementation
    |
   ::: src/main.rs:111:5
    |
111 | /     async fn resolve_source(
112 | |         &self,
113 | |         app: &App,
114 | |     ) -> Result<FileSource>;
    | |____________________________- `resolve_source` from trait

Check failure on line 143 in src/model/downloadable/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

not all trait items implemented, missing: `resolve_source`

error[E0046]: not all trait items implemented, missing: `resolve_source`
   --> src/model/downloadable/mod.rs:143:1
    |
143 |   impl Source for Downloadable {
    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ missing `resolve_source` in implementation
    |
   ::: src/main.rs:111:5
    |
111 | /     async fn resolve_source(
112 | |         &self,
113 | |         app: &App,
114 | |     ) -> Result<FileSource>;
    | |____________________________- `resolve_source` from trait

Check failure on line 32 in src/util/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

no method named `download` found for reference `&impl Source` in the current scope

error[E0599]: no method named `download` found for reference `&impl Source` in the current scope
  --> src/util/mod.rs:32:10
   |
31 |       let response = downloadable
   |  ____________________-
32 | |         .download(server, client)
   | |         -^^^^^^^^ method not found in `&impl Source`
   | |_________|
   | 

Check failure on line 104 in src/model/downloadable/markdown.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the size for values of type `str` cannot be known at compilation time

error[E0277]: the size for values of type `str` cannot be known at compilation time
   --> src/model/downloadable/markdown.rs:104:70
    |
104 |                 let desc = fetch_repo_description(client, repo).await?;
    |                                                                      ^ doesn't have a size known at compile-time
    |
    = help: the trait `std::marker::Sized` is not implemented for `str`
note: required by a bound in `std::ops::ControlFlow::Break`
   --> /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/ops/control_flow.rs:93:5

Check failure on line 104 in src/model/downloadable/markdown.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the size for values of type `str` cannot be known at compilation time

error[E0277]: the size for values of type `str` cannot be known at compilation time
   --> src/model/downloadable/markdown.rs:104:28
    |
104 |                 let desc = fetch_repo_description(client, repo).await?;
    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ doesn't have a size known at compile-time
    |
    = help: the trait `std::marker::Sized` is not implemented for `str`
    = note: all local variables must have a statically known size
    = help: unsized locals are gated as an unstable feature

Check failure on line 104 in src/model/downloadable/markdown.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the size for values of type `str` cannot be known at compilation time

error[E0277]: the size for values of type `str` cannot be known at compilation time
   --> src/model/downloadable/markdown.rs:104:21
    |
104 |                 let desc = fetch_repo_description(client, repo).await?;
    |                     ^^^^ doesn't have a size known at compile-time
    |
    = help: the trait `std::marker::Sized` is not implemented for `str`
    = note: all local variables must have a statically known size
    = help: unsized locals are gated as an unstable feature

Check failure on line 203 in src/model/downloadable/packwiz.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

no method named `get_filename` found for reference `&model::downloadable::Downloadable` in the current scope

error[E0599]: no method named `get_filename` found for reference `&model::downloadable::Downloadable` in the current scope
   --> src/model/downloadable/packwiz.rs:203:37
    |
203 |                 let filename = self.get_filename(server, http_client).await?;
    |                                     ^^^^^^^^^^^^ help: there is a method with a similar name: `get_type_name`

Check failure on line 537 in src/util/mrpack.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

no method named `get_filename` found for reference `&model::downloadable::Downloadable` in the current scope

error[E0599]: no method named `get_filename` found for reference `&model::downloadable::Downloadable` in the current scope
   --> src/util/mrpack.rs:537:35
    |
537 |                 let filename = dl.get_filename(server, http_client).await?;
    |                                   ^^^^^^^^^^^^ help: there is a method with a similar name: `get_type_name`

Check failure on line 426 in src/util/mrpack.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

no method named `get_filename` found for reference `&model::downloadable::Downloadable` in the current scope

error[E0599]: no method named `get_filename` found for reference `&model::downloadable::Downloadable` in the current scope
   --> src/util/mrpack.rs:426:35
    |
426 |                 let filename = dl.get_filename(server, http_client).await?;
    |                                   ^^^^^^^^^^^^ help: there is a method with a similar name: `get_type_name`

Check failure on line 179 in src/core/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

no method named `get_filename` found for reference `&impl Source + std::fmt::Debug` in the current scope

error[E0599]: no method named `get_filename` found for reference `&impl Source + std::fmt::Debug` in the current scope
   --> src/core/mod.rs:179:14
    |
178 |           let file_name = dl
    |  _________________________-
179 | |             .get_filename(&self.server, &self.http_client)
    | |             -^^^^^^^^^^^^ method not found in `&impl Source + std::fmt::Debug`
    | |_____________|
    | 

Check warning on line 4 in src/sources/hangar.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `VersionsFilter`

warning: unused import: `VersionsFilter`
 --> src/sources/hangar.rs:4:21
  |
4 | use mcapi::hangar::{VersionsFilter, ProjectVersion, Platform};
  |                     ^^^^^^^^^^^^^^

Check failure on line 135 in src/model/servertoml/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this `else { if .. }` block can be collapsed

error: this `else { if .. }` block can be collapsed
   --> src/model/servertoml/mod.rs:129:20
    |
129 |               } else {
    |  ____________________^
130 | |                 if is_vanilla {
131 | |                     v.loaders.contains(&"datapack".to_owned())
132 | |                 } else {
133 | |                     true
134 | |                 }
135 | |             }
    | |_____________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if
note: the lint level is defined here
   --> src/main.rs:1:9
    |
1   | #![deny(clippy::all)]
    |         ^^^^^^^^^^^
    = note: `#[deny(clippy::collapsible_else_if)]` implied by `#[deny(clippy::all)]`
help: collapse nested if block
    |
129 ~             } else if is_vanilla {
130 +                 v.loaders.contains(&"datapack".to_owned())
131 +             } else {
132 +                 true
133 +             }
    |

Check warning on line 14 in src/model/downloadable/packwiz.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `Source`

warning: unused import: `Source`
  --> src/model/downloadable/packwiz.rs:14:5
   |
14 |     Source,
   |     ^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

Check failure on line 459 in src/model/servertype/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

cannot find function `fetch_fabric_latest_installer` in module `fabric`

error[E0425]: cannot find function `fetch_fabric_latest_installer` in module `fabric`
   --> src/model/servertype/mod.rs:459:41
    |
459 |                     "latest" => fabric::fetch_fabric_latest_installer(client).await?,
    |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in `fabric`

Check failure on line 454 in src/model/servertype/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

cannot find function `fetch_fabric_latest_loader` in module `fabric`

error[E0425]: cannot find function `fetch_fabric_latest_loader` in module `fabric`
   --> src/model/servertype/mod.rs:454:41
    |
454 |                     "latest" => fabric::fetch_fabric_latest_loader(client).await?,
    |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^ not found in `fabric`

Check failure on line 369 in src/model/servertype/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

cannot find function `download_fabric` in module `fabric`

error[E0425]: cannot find function `download_fabric` in module `fabric`
   --> src/model/servertype/mod.rs:369:28
    |
369 |                 Ok(fabric::download_fabric(client, &mcver, loader, installer).await?)
    |                            ^^^^^^^^^^^^^^^ not found in `fabric`

Check failure on line 25 in src/commands/version.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

cannot find function `fetch_github_releases` in module `github`

error[E0425]: cannot find function `fetch_github_releases` in module `github`
  --> src/commands/version.rs:25:28
   |
25 |     let releases = github::fetch_github_releases(&repo_name, &http_client).await?;
   |                            ^^^^^^^^^^^^^^^^^^^^^ not found in `github`