Skip to content

progress

progress #205

GitHub Actions / clippy failed Jun 2, 2024 in 0s

clippy

7 errors, 41 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 7
Warning 41
Note 0
Help 0

Versions

  • rustc 1.78.0 (9b00956e5 2024-04-29)
  • cargo 1.78.0 (54d8815d0 2024-03-26)
  • clippy 0.1.78 (9b00956 2024-04-29)

Annotations

Check warning on line 18 in src/commands/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused `async` for function with no await statements

warning: unused `async` for function with no await statements
  --> src/commands/init.rs:14:1
   |
14 | / pub async fn run(mut app: App, args: Args) -> Result<()> {
15 | |     
16 | |
17 | |     Ok(())
18 | | }
   | |_^
   |
   = help: consider removing the `async` from this function
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

Check warning on line 40 in src/api/app/actions/init/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused `async` for function with no await statements

warning: unused `async` for function with no await statements
  --> src/api/app/actions/init/mod.rs:27:5
   |
27 | /     pub async fn init_network(&mut self) -> Result<()> {
28 | |         intro("initializing network")?;
29 | |
30 | |         let name: String = input("Name of the network?")
...  |
39 | |         Ok(())
40 | |     }
   | |_____^
   |
   = help: consider removing the `async` from this function
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

Check warning on line 25 in src/api/app/actions/init/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused `async` for function with no await statements

warning: unused `async` for function with no await statements
  --> src/api/app/actions/init/mod.rs:10:5
   |
10 | /     pub async fn init_server(&mut self) -> Result<()> {
11 | |         intro("initializing server")?;
12 | |
13 | |         let name: String = input("Name of the server?")
...  |
24 | |         Ok(())
25 | |     }
   | |_____^
   |
   = help: consider removing the `async` from this function
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

Check warning on line 13 in src/api/models/packwiz/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused `async` for function with no await statements

warning: unused `async` for function with no await statements
  --> src/api/models/packwiz/mod.rs:11:5
   |
11 | /     pub async fn into_addon(&self) -> Result<Addon> {
12 | |         todo!()
13 | |     }
   | |_____^
   |
   = help: consider removing the `async` from this function
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

Check warning on line 37 in src/api/models/addon/addon_source.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused `async` for function with no await statements

warning: unused `async` for function with no await statements
  --> src/api/models/addon/addon_source.rs:23:5
   |
23 | /     pub async fn resolve(&self, app: &App) -> Result<Vec<Addon>> {
24 | |         match self {
25 | |             AddonSource::File { path } => {
26 | |                 Ok(vec![])
...  |
36 | |         }
37 | |     }
   | |_____^
   |
   = help: consider removing the `async` from this function
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

Check warning on line 25 in src/api/models/addon/addon.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused `async` for function with no await statements

warning: unused `async` for function with no await statements
  --> src/api/models/addon/addon.rs:23:5
   |
23 | /     async fn resolve_steps(&self) -> Result<Vec<Step>> {
24 | |         Ok(vec![])
25 | |     }
   | |_____^
   |
   = help: consider removing the `async` from this function
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async

Check warning on line 48 in src/api/models/step.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused `async` for function with no await statements

warning: unused `async` for function with no await statements
  --> src/api/models/step.rs:46:5
   |
46 | /     async fn run(&self) -> Result<StepResult> {
47 | |         Ok(StepResult::Continue)
48 | |     }
   | |_____^
   |
   = help: consider removing the `async` from this function
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async
   = note: `-W clippy::unused-async` implied by `-W clippy::pedantic`
   = help: to override `-W clippy::pedantic` add `#[allow(clippy::unused_async)]`

Check failure on line 47 in src/api/app/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

error: this expression creates a reference which is immediately dereferenced by the compiler
  --> src/api/app/mod.rs:47:51
   |
47 |                 addons.append(&mut source.resolve(&self).await?);
   |                                                   ^^^^^ help: change this to: `self`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
   = note: `-D clippy::needless-borrow` implied by `-D clippy::all`
   = help: to override `-D clippy::all` add `#[allow(clippy::needless_borrow)]`

Check warning on line 30 in src/api/models/server/server_flavor.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this match arm has an identical body to another arm

warning: this match arm has an identical body to another arm
  --> src/api/models/server/server_flavor.rs:30:13
   |
30 |             ServerFlavor::Patched => true,
   |             ---------------------^^^^^^^^
   |             |
   |             help: try merging the arm patterns: `ServerFlavor::Patched | ServerFlavor::Proxy`
   |
   = help: or try changing either arm body
note: other arm here
  --> src/api/models/server/server_flavor.rs:31:13
   |
31 |             ServerFlavor::Proxy => true,
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms

Check warning on line 29 in src/api/models/server/server_flavor.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this match arm has an identical body to another arm

warning: this match arm has an identical body to another arm
  --> src/api/models/server/server_flavor.rs:29:13
   |
29 |             ServerFlavor::Modded => false,
   |             --------------------^^^^^^^^^
   |             |
   |             help: try merging the arm patterns: `ServerFlavor::Modded | ServerFlavor::Vanilla`
   |
   = help: or try changing either arm body
note: other arm here
  --> src/api/models/server/server_flavor.rs:28:13
   |
28 |             ServerFlavor::Vanilla => false,
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms

Check warning on line 26 in src/api/models/server/server_flavor.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)

warning: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)
  --> src/api/models/server/server_flavor.rs:26:29
   |
26 |     pub fn supports_plugins(&self) -> bool {
   |                             ^^^^^ help: consider passing by value instead: `self`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

Check failure on line 23 in src/api/models/server/server_flavor.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

match expression looks like `matches!` macro

error: match expression looks like `matches!` macro
  --> src/api/models/server/server_flavor.rs:20:9
   |
20 | /         match self {
21 | |             ServerFlavor::Modded => true,
22 | |             _ => false,
23 | |         }
   | |_________^ help: try: `matches!(self, ServerFlavor::Modded)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro

Check warning on line 19 in src/api/models/server/server_flavor.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)

warning: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)
  --> src/api/models/server/server_flavor.rs:19:26
   |
19 |     pub fn supports_mods(&self) -> bool {
   |                          ^^^^^ help: consider passing by value instead: `self`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref

Check failure on line 16 in src/api/models/server/server_flavor.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

match expression looks like `matches!` macro

error: match expression looks like `matches!` macro
  --> src/api/models/server/server_flavor.rs:13:9
   |
13 | /         match self {
14 | |             ServerFlavor::Proxy => false,
15 | |             _ => true,
16 | |         }
   | |_________^ help: try: `!matches!(self, ServerFlavor::Proxy)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro
   = note: `-D clippy::match-like-matches-macro` implied by `-D clippy::all`
   = help: to override `-D clippy::all` add `#[allow(clippy::match_like_matches_macro)]`

Check warning on line 12 in src/api/models/server/server_flavor.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)

warning: this argument (1 byte) is passed by reference, but would be more efficient if passed by value (limit: 8 byte)
  --> src/api/models/server/server_flavor.rs:12:31
   |
12 |     pub fn supports_datapacks(&self) -> bool {
   |                               ^^^^^ help: consider passing by value instead: `self`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
   = note: `-W clippy::trivially-copy-pass-by-ref` implied by `-W clippy::pedantic`
   = help: to override `-W clippy::pedantic` add `#[allow(clippy::trivially_copy_pass_by_ref)]`

Check warning on line 2 in src/api/models/server/server_type.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

usage of wildcard import

warning: usage of wildcard import
 --> src/api/models/server/server_type.rs:2:5
  |
2 | use crate::api::utils::serde::*;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `crate::api::utils::serde::str_latest`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_imports
  = note: `-W clippy::wildcard-imports` implied by `-W clippy::pedantic`
  = help: to override `-W clippy::pedantic` add `#[allow(clippy::wildcard_imports)]`

Check failure on line 11 in src/api/models/packwiz/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

methods called `into_*` usually take `self` by value

error: methods called `into_*` usually take `self` by value
  --> src/api/models/packwiz/mod.rs:11:29
   |
11 |     pub async fn into_addon(&self) -> Result<Addon> {
   |                             ^^^^^
   |
   = help: consider choosing a less ambiguous name
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
   = note: `-D clippy::wrong-self-convention` implied by `-D clippy::all`
   = help: to override `-D clippy::all` add `#[allow(clippy::wrong_self_convention)]`

Check warning on line 18 in src/api/models/addon/addon.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field name starts with the struct's name

warning: field name starts with the struct's name
  --> src/api/models/addon/addon.rs:18:5
   |
18 |     pub addon_type: AddonType,
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#struct_field_names
   = note: `-W clippy::struct-field-names` implied by `-W clippy::pedantic`
   = help: to override `-W clippy::pedantic` add `#[allow(clippy::struct_field_names)]`

Check failure on line 1 in src/api/models/addon/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

module has the same name as its containing module

error: module has the same name as its containing module
 --> src/api/models/addon/mod.rs:1:1
  |
1 | mod addon;
  | ^^^^^^^^^^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
  = note: `-D clippy::module-inception` implied by `-D clippy::all`
  = help: to override `-D clippy::all` add `#[allow(clippy::module_inception)]`

Check warning on line 30 in src/api/models/modpack_source.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this match arm has an identical body to another arm

warning: this match arm has an identical body to another arm
  --> src/api/models/modpack_source.rs:30:13
   |
30 |             Self::Remote { modpack_type, .. } => *modpack_type,
   |             ---------------------------------^^^^^^^^^^^^^^^^^
   |             |
   |             help: try merging the arm patterns: `Self::Remote { modpack_type, .. } | Self::Local { modpack_type, .. }`
   |
   = help: or try changing either arm body
note: other arm here
  --> src/api/models/modpack_source.rs:29:13
   |
29 |             Self::Local { modpack_type, .. } => *modpack_type,
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms
   = note: `-W clippy::match-same-arms` implied by `-W clippy::pedantic`
   = help: to override `-W clippy::pedantic` add `#[allow(clippy::match_same_arms)]`

Check failure on line 24 in Cargo.toml

See this annotation in the file changed.

@github-actions github-actions / clippy

lint group `pedantic` has the same priority (0) as a lint

error: lint group `pedantic` has the same priority (0) as a lint
  --> Cargo.toml:24:1
   |
24 | pedantic = "warn"
   | ^^^^^^^^   ------ has an implicit priority of 0
25 | missing_docs_in_private_items = "allow"
   | ----------------------------- has the same priority as this lint
   |
   = note: the order of the lints in the table is ignored by Cargo
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
help: to have lints override the group set `pedantic` to a lower priority
   |
24 | pedantic = { level = "warn", priority = -1 }
   |            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check failure on line 23 in Cargo.toml

See this annotation in the file changed.

@github-actions github-actions / clippy

lint group `all` has the same priority (0) as a lint

error: lint group `all` has the same priority (0) as a lint
  --> Cargo.toml:23:1
   |
23 | all = "deny"
   | ^^^   ------ has an implicit priority of 0
24 | pedantic = "warn"
25 | missing_docs_in_private_items = "allow"
   | ----------------------------- has the same priority as this lint
   |
   = note: the order of the lints in the table is ignored by Cargo
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lint_groups_priority
   = note: `-D clippy::lint-groups-priority` implied by `-D clippy::all`
   = help: to override `-D clippy::all` add `#[allow(clippy::lint_groups_priority)]`
help: to have lints override the group set `all` to a lower priority
   |
23 | all = { level = "deny", priority = -1 }
   |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Check warning on line 3 in src/api/utils/accessor.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

enum `Accessor` is never used

warning: enum `Accessor` is never used
 --> src/api/utils/accessor.rs:3:10
  |
3 | pub enum Accessor {
  |          ^^^^^^^^

Check warning on line 10 in src/api/app/actions/init/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

methods `init_server` and `init_network` are never used

warning: methods `init_server` and `init_network` are never used
  --> src/api/app/actions/init/mod.rs:10:18
   |
9  | impl App {
   | -------- methods in this implementation
10 |     pub async fn init_server(&mut self) -> Result<()> {
   |                  ^^^^^^^^^^^
...
27 |     pub async fn init_network(&mut self) -> Result<()> {
   |                  ^^^^^^^^^^^^

Check warning on line 40 in src/api/app/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

method `collect_addons` is never used

warning: method `collect_addons` is never used
  --> src/api/app/mod.rs:40:18
   |
25 | impl App {
   | -------- method in this implementation
...
40 |     pub async fn collect_addons(&self) -> Result<Vec<Addon>> {
   |                  ^^^^^^^^^^^^^^