Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure k8s pod names/labels are RFC 1123 compliant #3639

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Ensure k8s pod names/labels are RFC 1123 compliant #3639

wants to merge 4 commits into from
+292 −29

Commits on Oct 21, 2024

  1. Add utils to sanitize strings for DNS compliance 

    These convert any string to a valid RFC 1123 DNS subdomain or label.
    @rjmello
    rjmello committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    4edaddc View commit details
    Browse the repository at this point in the history

  2. Ensure k8s pod names/labels are RFC 1123 compliant 

    - Modified Kubernetes pod names and labels to conform to RFC 1123 for
DNS subdomain names and labels, ensuring compliance with Kubernetes
naming conventions.

- Replaced the trailing timestamp in the job name with an eight-character
hex string (job ID) to improve collision avoidance.

- Replaced `app` pod label with `parsl-job-id`.

- Updated container name to use job ID.
    @rjmello
    rjmello committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    22513c9 View commit details
    Browse the repository at this point in the history

  3. Use hex value for k8s job ID instead of pod name

    @rjmello
    rjmello committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    242abd0 View commit details
    Browse the repository at this point in the history

  4. Add tests for KubernetesProvider submit

    @rjmello
    rjmello committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    7752073 View commit details
    Browse the repository at this point in the history