Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement weighted distances #17

Merged
merged 4 commits into from
Sep 15, 2023
Merged

Conversation

SeviJordi
Copy link
Collaborator

He optimizado el cálculo de las distancias ponderadas seleccionando las posiciones sobre las que iterar en lugar de iterar sobre todo el genoma.
En mi ordenador, las 12 muestras de estudio tardaban anted 20 min y ahora 10 segundos.

@SeviJordi SeviJordi added the enhancement New feature or request label Sep 13, 2023
@SeviJordi SeviJordi closed this Sep 13, 2023
@SeviJordi SeviJordi reopened this Sep 13, 2023
@SeviJordi SeviJordi changed the base branch from main to dev September 13, 2023 09:49
Copy link
Member

@ahmig ahmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall but there are a couple of style errors. Also, we'll need to rework the name of some variables before release...

workflow/scripts/weighted_distances.py Show resolved Hide resolved
workflow/scripts/weighted_distances.py Outdated Show resolved Hide resolved
Copy link
Member

@ahmig ahmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing CI 😢

workflow/scripts/weighted_distances.py Outdated Show resolved Hide resolved
@SeviJordi SeviJordi merged commit f189506 into dev Sep 15, 2023
8 checks passed
@SeviJordi SeviJordi deleted the enhancement-weighted-distances branch September 15, 2023 09:59
SeviJordi added a commit that referenced this pull request Oct 20, 2023
ahmig pushed a commit that referenced this pull request Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants