Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix *ToTime_t macros to work with the Arduino compiler #145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tomer-w
Copy link

@tomer-w tomer-w commented Mar 1, 2020

The daysToTime_t (and all other similar macros) does not compile correctly on recent Arduino SDK.
Apparently the compiler require that there will be no space between the macro name and the (x) parameter definition.

The daysToTime_t (and all other similar macros) does not compile correctly on recent Arduino SDK.
Apparently the compiler require that there will be no space between the macro name and the (x) parameter definition.
@46Leo
Copy link

46Leo commented Oct 31, 2020

I can confirm the issue with Arduino IDE 1.8.13 on Windows 10.
The solution for me was removing space and double parentheses, as you did in your modified header.

@jpasqua
Copy link

jpasqua commented Oct 30, 2021

Same issue with:
Arduino IDE: 1.8.13
Boards: Uno, ESP8266, ESP32
Compiler VERSION for ESP8266: 4.8.2

@tomer-w
Copy link
Author

tomer-w commented Apr 8, 2023

ping...

@murmlgrmpf
Copy link

@PaulStoffregen Thanks for the brilliant library!
Please consider to apply this pr, it is fixing the issue of the broken makros for me as well.
I am working with up to date PIO in VSC and my target is a mega2560.

@tomer-w
Copy link
Author

tomer-w commented Aug 15, 2023

@murmlgrmpf , I hate to say it, but this repository is dead. Last checkin was 2021. This is what happen with OSS when there is no continuity and people change focus without nominating people who will replace them as maintainers.

@tomer-w
Copy link
Author

tomer-w commented Aug 15, 2023

Actually, I'm taking it back. Seems @PaulStoffregen was active on github lately. Maybe he is just ignoring this repository specifically.

@tomer-w
Copy link
Author

tomer-w commented Aug 15, 2023

Actually, i'm taking it back. Seems @PaulStoffregen was active on github lately. Maybe there is a chance this will get fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants