Fix FilteredBlockstore.has (I'm a clown)

Add a test for it too.
Peergos · Sep 30, 2024 · d9018ae · d9018ae
1 parent c359692
commit d9018ae
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/main/java/org/peergos/blockstore/FilteredBlockstore.java b/src/main/java/org/peergos/blockstore/FilteredBlockstore.java
@@ -48,7 +48,7 @@ public CompletableFuture<Boolean> has(Cid c) {
             return blocks.has(c).thenApply(res -> {
                 if (! res)
                     addAbsentBlock(c);
-                return false;
+                return res;
             });
         return CompletableFuture.completedFuture(false);
     }

diff --git a/src/test/java/org/peergos/blockstore/BloomTest.java b/src/test/java/org/peergos/blockstore/BloomTest.java
@@ -33,6 +33,10 @@ public void bloom() {
         long t4 = System.currentTimeMillis();
         System.out.println("Doubling filter size took: " + (t4-t3)+ "ms");
 
+        for (Cid ref : bs.refs(false).join()) {
+            Assert.assertTrue(filtered.has(ref).join());
+        }
+
         checkFalsePositiveRate(bloom, 14);
     }