Optimise IPNS publishing and resolution #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure we iclude /ipns/ in key wqhen publishing a value Use GET_VALUE calls only when looking up a value (using returned closer peers to iterate) Most IPNS lookups are now < 1s
kevodwyer
approved these changes
Dec 12, 2023
This slows down publishing to 11s (a large fraction of closest nodes may be quic only, so we need to try next closest)
Put record in local store during publish
Include any local value in results
kevodwyer
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings publish times down to ~4-14s and resolution times to mostly ~0.5-3s
We also add an api to EmbeddedIpfs for this, includikng publishing presigned records.