Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant files added in first commit #6

Closed
wants to merge 5 commits into from

Conversation

gwaybio
Copy link
Member

@gwaybio gwaybio commented Sep 21, 2017

These lab1 files are the same as the files @sklasfeld added in a previous commit. Organizing the repository by lab, rather than by content, would maintain focus and I think is a better organization strategy.

This PR removes these redundant files I added previously

@sklasfeld
Copy link
Collaborator

sklasfeld commented Sep 21, 2017

Where did you get these files? Were they from Raju? If so, were they edited in anyway from Sarah's slides? Maybe they are more updated and should replace the slides I put in lab1/py27.

@gwaybio
Copy link
Member Author

gwaybio commented Sep 21, 2017

I downloaded them directly from Piazza. Does that mean they are more recent?

@sklasfeld
Copy link
Collaborator

yeah and it looks like they are also in Python2.7 so maybe you should just replace the files I put in the py27 directory.

@gwaybio
Copy link
Member Author

gwaybio commented Sep 21, 2017

alright, i believe I replaced the files - look ok to you @sklasfeld ?

@sklasfeld
Copy link
Collaborator

Sorry, I must have been looking at the wrong files. These are in python3. Therefore, they just need to go in a new directory 'lab1/py3'. Sorry for the confusion. The rest of the stuff from Piazza should also go in py3 folders. I wasn't sure if Raju already made the switch in the first lecture. I guess she did.

@gwaybio
Copy link
Member Author

gwaybio commented Sep 21, 2017

yeah it does look like the jupyter kernel is using python 3, but the code written will only execute in python 2 - e.g. print "what's", "up" will not work in python 3. Perhaps instead it would be best to revert the kernel instead of moving the file.

@gwaybio
Copy link
Member Author

gwaybio commented Sep 21, 2017

next year this will not be an issue if #4 is completed and the course is run on Github

@sklasfeld sklasfeld closed this Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants