Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DatasetLinks to dataset_description.json #77

Merged
merged 7 commits into from
Aug 22, 2024
Merged

Add DatasetLinks to dataset_description.json #77

merged 7 commits into from
Aug 22, 2024

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Aug 20, 2024

Related to #69.

Changes proposed in this pull request

  • Build dictionary of dataset links and add them to the dataset_description.json file.

@tsalo tsalo marked this pull request as draft August 20, 2024 18:35
@tsalo tsalo added the enhancement New feature or request label Aug 20, 2024
@tsalo tsalo marked this pull request as ready for review August 20, 2024 19:29
@tsalo tsalo requested a review from mattcieslak August 20, 2024 19:33
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 56.60377% with 23 lines in your changes missing coverage. Please review.

Project coverage is 33.72%. Comparing base (0c9bdce) to head (812323d).

Files Patch % Lines
qsirecon/utils/bids.py 53.33% 12 Missing and 9 partials ⚠️
qsirecon/config.py 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
+ Coverage   33.57%   33.72%   +0.15%     
==========================================
  Files          56       56              
  Lines        6886     6917      +31     
  Branches      894      907      +13     
==========================================
+ Hits         2312     2333      +21     
- Misses       4477     4481       +4     
- Partials       97      103       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

qsirecon/utils/bids.py Outdated Show resolved Hide resolved
qsirecon/utils/bids.py Outdated Show resolved Hide resolved
@tsalo tsalo requested a review from mattcieslak August 22, 2024 19:00
Copy link
Contributor

@mattcieslak mattcieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!!

@mattcieslak mattcieslak merged commit 4aff38a into main Aug 22, 2024
18 checks passed
@tsalo tsalo deleted the metadata branch August 22, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants